feat: ResourceDefinition CRD + /v1/resource-definitions CRUD

Phase 2 third slice. ResourceDefinition is the named entity per PVC; one RD
becomes one or more Resources (replicas) at autoplace time.

- pkg/api/v1: ResourceDefinition wire shape + ResourceDefinitionCreate
  wrapper (POST body shape upstream uses).
- api/v1alpha1: CRD with externalName, resourceGroupName, props, flags,
  volumeDefinitions.
- pkg/store: ResourceDefinitionStore interface + InMemory + k8s impl;
  shared 6-case suite (list-empty, create→get, dup→409, get-missing→404,
  delete-missing→404, delete-removes) green on both stores.
- pkg/rest/resource_definitions.go: 5 handlers; create unwraps the
  upstream {resource_definition: {...}} envelope.
- 5 contract tests against golinstor (list, create round-trip via
  ResourceDefinitionCreate, conflict→409, get-missing→404, delete cascades,
  503-without-store).

CSI MVP api-surface.md: 5/12 RD endpoints ✅.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Author: kvaps

.golangci.yml

@@ -75,6 +75,7 @@ linters:
         - in
         - sp
         - st
+        - s
         - rd
         - vd
         - rg
@@ -124,6 +125,10 @@ linters:
       - linters:
           - dupl
         path: pkg/store/k8s/
+      # Same applies to the in-memory store implementations.
+      - linters:
+          - dupl
+        path: pkg/store/inmemory_
       # REST handlers follow the same Get/Create/Update/Delete shape per
       # resource for the same reason.
       - linters:

PROJECT

@@ -33,4 +33,12 @@ resources:
   kind: ResourceGroup
   path: github.com/cozystack/blockstor/api/v1alpha1
   version: v1alpha1
+- api:
+    crdVersion: v1
+  controller: true
+  domain: blockstor.io
+  group: blockstor.io
+  kind: ResourceDefinition
+  path: github.com/cozystack/blockstor/api/v1alpha1
+  version: v1alpha1
 version: "3"

api/v1alpha1/resourcedefinition_types.go

@@ -0,0 +1,101 @@
+/*
+Copyright 2026 Cozystack contributors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package v1alpha1
+
+import (
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+// ResourceDefinitionSpec is the desired state of a LINSTOR
+// ResourceDefinition — the named entity from which Resource (replica)
+// instances are spawned. linstor-csi creates one per PVC.
+type ResourceDefinitionSpec struct {
+	// externalName is the user-facing name surfaced by csi (CSI volume id).
+	// Empty means the same as metadata.name.
+	// +optional
+	ExternalName string `json:"externalName,omitempty"`
+
+	// resourceGroupName references the ResourceGroup template this RD was
+	// spawned from (or empty if directly created).
+	// +optional
+	ResourceGroupName string `json:"resourceGroupName,omitempty"`
+
+	// props is the LINSTOR property map.
+	// +optional
+	Props map[string]string `json:"props,omitempty"`
+
+	// flags carries user-controlled RD flags (DELETE, INACTIVE, ...).
+	// +optional
+	Flags []string `json:"flags,omitempty"`
+
+	// volumeDefinitions are the volume slots inside this RD.
+	// +optional
+	VolumeDefinitions []ResourceDefinitionVolume `json:"volumeDefinitions,omitempty"`
+}
+
+// ResourceDefinitionVolume is one volume slot inside an RD.
+type ResourceDefinitionVolume struct {
+	VolumeNumber int32 `json:"volumeNumber"`
+	SizeKib      int64 `json:"sizeKib"`
+	// +optional
+	Props map[string]string `json:"props,omitempty"`
+	// +optional
+	Flags []string `json:"flags,omitempty"`
+}
+
+// ResourceDefinitionStatus is the observed state.
+type ResourceDefinitionStatus struct {
+	// conditions represent the current state of the ResourceDefinition.
+	// +listType=map
+	// +listMapKey=type
+	// +optional
+	Conditions []metav1.Condition `json:"conditions,omitempty"`
+}
+
+// +kubebuilder:object:root=true
+// +kubebuilder:subresource:status
+// +kubebuilder:resource:scope=Cluster
+
+// ResourceDefinition is the Schema for the resourcedefinitions API
+type ResourceDefinition struct {
+	metav1.TypeMeta `json:",inline"`
+
+	// metadata is a standard object metadata
+	// +optional
+	metav1.ObjectMeta `json:"metadata,omitzero"`
+
+	// spec defines the desired state of ResourceDefinition
+	// +required
+	Spec ResourceDefinitionSpec `json:"spec"`
+
+	// status defines the observed state of ResourceDefinition
+	// +optional
+	Status ResourceDefinitionStatus `json:"status,omitzero"`
+}
+
+// +kubebuilder:object:root=true
+
+// ResourceDefinitionList contains a list of ResourceDefinition
+type ResourceDefinitionList struct {
+	metav1.TypeMeta `json:",inline"`
+	metav1.ListMeta `json:"metadata,omitzero"`
+	Items           []ResourceDefinition `json:"items"`
+}
+
+func init() {
+	SchemeBuilder.Register(&ResourceDefinition{}, &ResourceDefinitionList{})
+}

api/v1alpha1/zz_generated.deepcopy.go

@@ -207,6 +207,13 @@ func main() {
 		setupLog.Error(err, "Failed to create controller", "controller", "resourcegroup")
 		os.Exit(1)
 	}
+	if err := (&controller.ResourceDefinitionReconciler{
+		Client: mgr.GetClient(),
+		Scheme: mgr.GetScheme(),
+	}).SetupWithManager(mgr); err != nil {
+		setupLog.Error(err, "Failed to create controller", "controller", "resourcedefinition")
+		os.Exit(1)
+	}
 	// +kubebuilder:scaffold:builder
 
 	if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {