fix(store): uppercase satelliteEncryptionType + node Type for CRD enum

Upstream LINSTOR (and golinstor + piraeus-csi node-init) sends
satellite_encryption_type as "plain" / "ssl" lowercase. The CRD spec
enforces an enum of "PLAIN" / "SSL" only, so PUT /v1/nodes returned
500 with a kubebuilder validation error. Normalise on the way into
the CRD store; the wire shape stays whatever the caller sent.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Author: kvaps

pkg/store/k8s/nodes.go

@@ -19,6 +19,7 @@ package k8s
 import (
 	"context"
 	"sort"
+	"strings"
 
 	"github.com/cockroachdb/errors"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
@@ -207,9 +208,12 @@ func wireToCRDNode(in *apiv1.Node) *crdv1alpha1.Node {
 }
 
 // wireToCRDNodeSpec is the spec-only converter used by both Create and Update.
+// SatelliteEncryptionType is uppercased on the way in: upstream LINSTOR
+// accepts mixed case ("plain"/"PLAIN") but the CRD validation enum is
+// uppercase-only, so we normalise here to keep wire compatibility.
 func wireToCRDNodeSpec(in *apiv1.Node) crdv1alpha1.NodeSpec {
 	spec := crdv1alpha1.NodeSpec{
-		Type:  in.Type,
+		Type:  strings.ToUpper(in.Type),
 		Props: in.Props,
 		Flags: in.Flags,
 	}
@@ -222,7 +226,7 @@ func wireToCRDNodeSpec(in *apiv1.Node) crdv1alpha1.NodeSpec {
 				Name:                    ni.Name,
 				Address:                 ni.Address,
 				SatellitePort:           int32(ni.SatellitePort), //nolint:gosec // upstream LINSTOR ports fit in int32
-				SatelliteEncryptionType: ni.SatelliteEncryptionType,
+				SatelliteEncryptionType: strings.ToUpper(ni.SatelliteEncryptionType),
 			})
 		}
 	}

stand/csi-sanity-job.yaml

@@ -15,6 +15,23 @@ spec:
   template:
     spec:
       restartPolicy: Never
+      initContainers:
+        # csi-sanity is launched with --node=csi-sanity-node, so
+        # linstor-csi expects that name to exist as a Node before any
+        # CreateVolume call. Pre-register it as a SATELLITE — we don't
+        # care about its actual presence; the topology lookup just
+        # needs an entry.
+        - name: register-csi-sanity-node
+          image: curlimages/curl:8.10.1
+          command:
+            - sh
+            - -c
+            - |
+              set -e
+              curl -fsS -XPOST -H 'content-type: application/json' \
+                http://blockstor-controller.blockstor-system.svc:3370/v1/nodes \
+                -d '{"name":"csi-sanity-node","type":"SATELLITE","net_interfaces":[{"name":"default","address":"127.0.0.1","satellite_port":3366,"satellite_encryption_type":"PLAIN"}]}' \
+                || true
       containers:
         - name: linstor-csi
           image: quay.io/piraeusdatastore/piraeus-csi:v1.10.1