fix(controller): persist satellite ConnectionStatus via the Status subresource

Previous attempt set ConnectionStatus on the apiv1.Node value, but
nodes.Update only writes Spec — Status was untouched. Adds a
dedicated NodeStore.SetConnectionStatus method with both InMemory
and CRD-backed implementations; the CRD path goes through
client.Status().Update so the field actually lands.

Server.Hello calls SetConnectionStatus("ONLINE") after Create/Update;
linstor-csi-node's `linstor-wait-node-online` initContainer now sees
connection_status: "ONLINE" and the DaemonSet rolls past Init.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Author: kvaps

pkg/satellitecontroller/server.go

@@ -76,16 +76,10 @@ func (s *Server) Hello(ctx context.Context, req *satellitepb.HelloRequest) (*sat
 		"SatelliteEndpoint": req.GetSatelliteEndpoint(),
 	}
 
-	// Hello completes only after the satellite has dialled in, so by
-	// the time we're here the node is ONLINE in LINSTOR-speak. The
-	// piraeus init-container `linstor-wait-node-online` checks this
-	// exact field; without it linstor-csi-node DaemonSets stall on
-	// satellites we know perfectly well are alive.
 	node := apiv1.Node{
-		Name:             req.GetNodeName(),
-		Type:             apiv1.NodeTypeSatellite,
-		Props:            props,
-		ConnectionStatus: "ONLINE",
+		Name:  req.GetNodeName(),
+		Type:  apiv1.NodeTypeSatellite,
+		Props: props,
 	}
 
 	err := s.st.Nodes().Create(ctx, &node)
@@ -101,6 +95,16 @@ func (s *Server) Hello(ctx context.Context, req *satellitepb.HelloRequest) (*sat
 		return nil, status.Errorf(codes.Internal, "register Node %q: %v", req.GetNodeName(), err)
 	}
 
+	// Hello round-trips only after the satellite has dialled in;
+	// by the time we're here the node is ONLINE in LINSTOR-speak.
+	// linstor-csi-node's `linstor-wait-node-online` initContainer
+	// polls /v1/nodes/<name> for connection_status:"ONLINE" and
+	// stalls the DaemonSet otherwise.
+	err = s.st.Nodes().SetConnectionStatus(ctx, req.GetNodeName(), "ONLINE")
+	if err != nil {
+		return nil, status.Errorf(codes.Internal, "set Node %q ONLINE: %v", req.GetNodeName(), err)
+	}
+
 	return &satellitepb.HelloResponse{
 		ClusterId:          s.cfg.ClusterID,
 		ControllerEndpoint: s.cfg.ControllerEndpoint,

pkg/store/inmemory.go

@@ -161,3 +161,21 @@ func (s *inMemoryNodes) Delete(_ context.Context, name string) error {
 
 	return nil
 }
+
+// SetConnectionStatus mutates only the ConnectionStatus field on the
+// in-memory copy. Returns ErrNotFound if the node hasn't been
+// Create'd yet.
+func (s *inMemoryNodes) SetConnectionStatus(_ context.Context, name, status string) error {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+
+	node, ok := s.m[name]
+	if !ok {
+		return errors.Wrapf(ErrNotFound, "node %q", name)
+	}
+
+	node.ConnectionStatus = status
+	s.m[name] = node
+
+	return nil
+}

pkg/store/k8s/nodes.go

@@ -119,6 +119,33 @@ func (n *nodes) Update(ctx context.Context, in *apiv1.Node) error {
 	return nil
 }
 
+// SetConnectionStatus updates the Node CRD's
+// `.status.connectionStatus` via the Status subresource. Survives
+// subsequent Spec Update calls (which would otherwise overwrite
+// nothing here, but the dedicated subresource is the kubebuilder-
+// idiomatic place to land observed state).
+func (n *nodes) SetConnectionStatus(ctx context.Context, name, status string) error {
+	var existing crdv1alpha1.Node
+
+	err := n.c.Get(ctx, types.NamespacedName{Name: name}, &existing)
+	if err != nil {
+		if apierrors.IsNotFound(err) {
+			return errors.Wrapf(store.ErrNotFound, "node %q", name)
+		}
+
+		return errors.Wrapf(err, "get Node %q", name)
+	}
+
+	existing.Status.ConnectionStatus = status
+
+	err = n.c.Status().Update(ctx, &existing)
+	if err != nil {
+		return errors.Wrapf(err, "status update Node %q", name)
+	}
+
+	return nil
+}
+
 // Delete removes the named Node CRD.
 func (n *nodes) Delete(ctx context.Context, name string) error {
 	crd := &crdv1alpha1.Node{ObjectMeta: metav1.ObjectMeta{Name: name}}

pkg/store/store.go

@@ -48,6 +48,13 @@ type NodeStore interface {
 	Create(ctx context.Context, n *apiv1.Node) error
 	Update(ctx context.Context, n *apiv1.Node) error
 	Delete(ctx context.Context, name string) error
+
+	// SetConnectionStatus writes node.Status.ConnectionStatus directly
+	// via the Status subresource so it survives a subsequent Spec
+	// Update. linstor-csi's `linstor-wait-node-online` init container
+	// polls /v1/nodes/<name> for connection_status:"ONLINE"; this is
+	// where the satellite's gRPC Hello surfaces that state.
+	SetConnectionStatus(ctx context.Context, name, status string) error
 }
 
 // StoragePoolStore persists StoragePool objects. The composite key is