Skip to content

fix(e2e): test waits rediness against flaky e2e#325

Merged
Timofei Larkin (lllamnyp) merged 1 commit into
v1from
fix/e2e-flaky
Jun 5, 2026
Merged

fix(e2e): test waits rediness against flaky e2e#325
Timofei Larkin (lllamnyp) merged 1 commit into
v1from
fix/e2e-flaky

Conversation

@androndo

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Andrey Kolkov <androndo@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5c76b591-b863-4f1b-9579-a981aed05bef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-flaky

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bugfix label Jun 5, 2026
@androndo Andrey Kolkov (androndo) changed the title fix(e2e): pick a ready member pod for the etcd key dump fix(e2e): test waits all pods is ready against flaky e2e Jun 5, 2026
@androndo Andrey Kolkov (androndo) changed the title fix(e2e): test waits all pods is ready against flaky e2e fix(e2e): test waits rediness against flaky e2e Jun 5, 2026

@lllamnyp Timofei Larkin (lllamnyp) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the e2e flake at its root. etcdKeys now selects a member pod by readiness — Status.Phase == Running with a Ready etcd container — instead of pods.Items[0], and fails clearly if none exists. That's exactly the cause of the earlier container not found ("etcd"): the dump ran while a freshly-created member's container hadn't started. The comment captures the why (Available latches on quorum, not the full replica count; etcdctl get is linearizable, so any ready member returns the same keys).

Scope is test-only — one file, kamaji_datastore_test.go. Compiles under the e2e build tag, vet and full build pass, and the kamaji-datastore e2e check is green on this PR (~6m). Based cleanly on the current v1.

LGTM.

@lllamnyp Timofei Larkin (lllamnyp) merged commit cf88831 into v1 Jun 5, 2026
2 checks passed
@lllamnyp Timofei Larkin (lllamnyp) deleted the fix/e2e-flaky branch June 5, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants