fix(e2e): test waits rediness against flaky e2e#325
Conversation
Signed-off-by: Andrey Kolkov <androndo@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Timofei Larkin (lllamnyp)
left a comment
There was a problem hiding this comment.
Fixes the e2e flake at its root. etcdKeys now selects a member pod by readiness — Status.Phase == Running with a Ready etcd container — instead of pods.Items[0], and fails clearly if none exists. That's exactly the cause of the earlier container not found ("etcd"): the dump ran while a freshly-created member's container hadn't started. The comment captures the why (Available latches on quorum, not the full replica count; etcdctl get is linearizable, so any ready member returns the same keys).
Scope is test-only — one file, kamaji_datastore_test.go. Compiles under the e2e build tag, vet and full build pass, and the kamaji-datastore e2e check is green on this PR (~6m). Based cleanly on the current v1.
LGTM.
No description provided.