Add Basic Auth support#604
Open
lipaysamart wants to merge 3 commits into
Open
Conversation
- Add isPassword parameter to generateSimpleStringInputSetting() - Change input type from 'input' to 'password' for password field - Add autoComplete='new-password' to prevent browser auto-fill
Add Basic Auth support for Alertmanager HTTP requests - Fixes issue cpanato#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Basic Auth support for Alertmanager HTTP requests, fixing issue #7.
Changes
Backend (Server)
UserandPasswordfields toalertConfigstruct inconfiguration.goalertmanager/package to include Basic Auth:retry.go: Added auth parameters tohttpRetry()functionalerts.go: UpdatedListAlerts()with auth supportsilences.go: Updated silence management functionsstatus.go: Updated status query functionscommands.goto pass auth credentialsactions.goto pass auth credentialsFrontend (Webapp)
AMAttribute.jsxCustomAttributeSettings.jsxtype="password"for security (hidden input)autoComplete="new-password"to prevent browser auto-fillFiles Modified
server/configuration.go- Added User/Password config fieldsserver/alertmanager/retry.go- Core HTTP auth logicserver/alertmanager/alerts.go- Alerts API with authserver/alertmanager/silences.go- Silences API with authserver/alertmanager/status.go- Status API with authserver/commands.go- Command handlersserver/actions.go- Action handlerswebapp/src/components/admin_settings/AMAttribute.jsx- UI fieldswebapp/src/components/admin_settings/CustomAttributeSettings.jsx- Settings handlingFixes #7