You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix CI checks job to detect test failures (NVIDIA#1547)
The checks job only verified if jobs were cancelled, but did not check
if they failed. This allowed PRs to merge even when tests failed because
the checks job would exit with 0 (success) when tests had result='failure'.
Add failure checks alongside the existing cancellation checks for all
test jobs and the doc job.
Copy file name to clipboardExpand all lines: .github/workflows/ci.yml
+7-4Lines changed: 7 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -1,4 +1,4 @@
1
-
# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
1
+
# SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2
2
#
3
3
# SPDX-License-Identifier: Apache-2.0
4
4
@@ -223,7 +223,7 @@ jobs:
223
223
steps:
224
224
- name: Exit
225
225
run: |
226
-
# if any dependencies were cancelled, that's a failure
226
+
# if any dependencies were cancelled or failed, that's a failure
227
227
#
228
228
# see https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#always
229
229
# and https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
@@ -243,13 +243,16 @@ jobs:
243
243
# Note: When [doc-only] is in PR title, test jobs are intentionally
0 commit comments