Skip to content

Commit 2521055

Browse files
committed
Address review: remove WASM cmake-script regression test
Requested by @lefticus in PR #156 review.
1 parent 5fddb4b commit 2521055

2 files changed

Lines changed: 0 additions & 137 deletions

File tree

test/CMakeLists.txt

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,6 @@ add_test(
3434
COMMAND ${CMAKE_COMMAND} -P
3535
${CMAKE_CURRENT_SOURCE_DIR}/cmake/test_sanitizers_non_apple_includes_leak.cmake)
3636

37-
# CMake-script regression test for cmake/Emscripten.cmake (issue #155):
38-
# the legacy `-sASYNCIFY=1` flag is incompatible with `-fwasm-exceptions`
39-
# under modern emsdk; the WASM target must use the JSPI replacement.
40-
add_test(
41-
NAME cmake.emscripten.modern_async
42-
COMMAND ${CMAKE_COMMAND}
43-
-DTEST_TMP_DIR=${CMAKE_CURRENT_BINARY_DIR}/test_emscripten_modern_async
44-
-P ${CMAKE_CURRENT_SOURCE_DIR}/cmake/test_emscripten_modern_async.cmake)
45-
4637
# Provide a test to verify that the version being reported from the application
4738
# matches the version given to CMake. This will be important once you package
4839
# your program. Real world shows that this is the kind of simple mistake that is easy

test/cmake/test_emscripten_modern_async.cmake

Lines changed: 0 additions & 128 deletions
This file was deleted.

0 commit comments

Comments
 (0)