Skip to content

Commit 25dde07

Browse files
leftibotclaude
andauthored
Fix #117: Remove Conan from Dev Container (unused?) (#152)
* Fix #117: remove unused Conan install from dev container Conan was installed in `.devcontainer/Dockerfile` but never used; the project manages its dependencies via CPM (see Dependencies.cmake), so the `pip install conan` step and the `CONAN_SYSREQUIRES_*` environment variables were dead weight on every dev container build. Drop them, and add a CTest regression test that scans the Dockerfile to prevent Conan from being reintroduced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Address review: remove devcontainer Conan-removal regression test Requested by @lefticus in PR #152 review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: leftibot <leftibot@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 968f7d5 commit 25dde07

1 file changed

Lines changed: 0 additions & 14 deletions

File tree

.devcontainer/Dockerfile

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,6 @@ RUN apt-get update -qq && export DEBIAN_FRONTEND=noninteractive && \
1313
make ninja-build git \
1414
python3 python3-pip
1515

16-
# Install conan
17-
RUN python3 -m pip install --upgrade pip setuptools && \
18-
python3 -m pip install conan && \
19-
conan --version
20-
21-
# By default, anything you run in Docker is done as superuser.
22-
# Conan runs some install commands as superuser, and will prepend `sudo` to
23-
# these commands, unless `CONAN_SYSREQUIRES_SUDO=0` is in your env variables.
24-
ENV CONAN_SYSREQUIRES_SUDO 0
25-
# Some packages request that Conan use the system package manager to install
26-
# a few dependencies. This flag allows Conan to proceed with these installations;
27-
# leaving this flag undefined can cause some installation failures.
28-
ENV CONAN_SYSREQUIRES_MODE enabled
29-
3016
# User-settable versions:
3117
# This Dockerfile should support gcc-[7, 8, 9, 10, 11] and clang-[10, 11, 12, 13]
3218
# Earlier versions of clang will require significant modifications to the IWYU section

0 commit comments

Comments
 (0)