Fixes as needed for latest clang-tidy

Author: lefticus

.clang-tidy

@@ -13,6 +13,9 @@ Checks: "*,
         -readability-avoid-const-params-in-decls,
         -cppcoreguidelines-non-private-member-variables-in-classes,
         -misc-non-private-member-variables-in-classes,
+        -misc-no-recursion,
+        -misc-use-anonymous-namespace,
+        -misc-use-internal-linkage
 "
 WarningsAsErrors: ''
 HeaderFilterRegex: ''

CMakeLists.txt

@@ -6,7 +6,7 @@ cmake_minimum_required(VERSION 3.21)
 
 # Only set the cxx_standard if it is not set by someone else
 if (NOT DEFINED CMAKE_CXX_STANDARD)
-  set(CMAKE_CXX_STANDARD 20)
+  set(CMAKE_CXX_STANDARD 23)
 endif()
 
 # strongly encouraged to enable this globally to avoid conflicts between

cmake/CPM.cmake

@@ -1,4 +1,9 @@
-set(CPM_DOWNLOAD_VERSION 0.38.1)
+# SPDX-License-Identifier: MIT
+#
+# SPDX-FileCopyrightText: Copyright (c) 2019-2023 Lars Melchior and contributors
+
+set(CPM_DOWNLOAD_VERSION 0.40.8)
+set(CPM_HASH_SUM "78ba32abdf798bc616bab7c73aac32a17bbd7b06ad9e26a6add69de8f3ae4791")
 
 if(CPM_SOURCE_CACHE)
   set(CPM_DOWNLOAD_LOCATION "${CPM_SOURCE_CACHE}/cpm/CPM_${CPM_DOWNLOAD_VERSION}.cmake")
@@ -11,23 +16,9 @@ endif()
 # Expand relative path. This is important if the provided path contains a tilde (~)
 get_filename_component(CPM_DOWNLOAD_LOCATION ${CPM_DOWNLOAD_LOCATION} ABSOLUTE)
 
-function(download_cpm)
-  message(STATUS "Downloading CPM.cmake to ${CPM_DOWNLOAD_LOCATION}")
-  file(DOWNLOAD
-       https://github.com/cpm-cmake/CPM.cmake/releases/download/v${CPM_DOWNLOAD_VERSION}/CPM.cmake
-       ${CPM_DOWNLOAD_LOCATION}
-  )
-endfunction()
-
-if(NOT (EXISTS ${CPM_DOWNLOAD_LOCATION}))
-  download_cpm()
-else()
-  # resume download if it previously failed
-  file(READ ${CPM_DOWNLOAD_LOCATION} check)
-  if("${check}" STREQUAL "")
-    download_cpm()
-  endif()
-  unset(check)
-endif()
+file(DOWNLOAD
+     https://github.com/cpm-cmake/CPM.cmake/releases/download/v${CPM_DOWNLOAD_VERSION}/CPM.cmake
+     ${CPM_DOWNLOAD_LOCATION} EXPECTED_HASH SHA256=${CPM_HASH_SUM}
+)
 
 include(${CPM_DOWNLOAD_LOCATION})

fuzz_test/fuzz_tester.cpp

@@ -1,6 +1,7 @@
-#include <fmt/format.h>
+#include <cstdint>
+#include <cstddef>
+#include <fmt/base.h>
 #include <iterator>
-#include <utility>
 
 [[nodiscard]] auto sum_values(const uint8_t *Data, size_t Size)
 {

src/ftxui_sample/main.cpp

@@ -1,12 +1,21 @@
 #include <array>
+#include <cstddef>
+#include <ftxui/dom/elements.hpp>
+#include <cstdint>
+#include <ftxui/dom/node.hpp>
+#include <ftxui/screen/screen.hpp>
+#include <chrono>
+#include <atomic>
+#include <fmt/format.h>
+#include <fmt/base.h>
+#include <cstdlib>
+#include <exception>
 #include <functional>
-#include <iostream>
 #include <optional>
 
 #include <random>
 
 #include <CLI/CLI.hpp>
-#include <ftxui/component/captured_mouse.hpp>// for ftxui
 #include <ftxui/component/component.hpp>// for Slider
 #include <ftxui/component/screen_interactive.hpp>// for ScreenInteractive
 #include <spdlog/spdlog.h>
@@ -17,6 +26,10 @@
 // configuration step. It creates a namespace called `myproject`. You can modify
 // the source template at `configured_files/config.hpp.in`.
 #include <internal_use_only/config.hpp>
+#include <string>
+#include <vector>
+#include <utility>
+#include <thread>
 
 template<std::size_t Width, std::size_t Height> struct GameBoard
 {
@@ -89,7 +102,7 @@ template<std::size_t Width, std::size_t Height> struct GameBoard
   }
 };
 
-
+namespace {
 void consequence_game()
 {
   auto screen = ftxui::ScreenInteractive::TerminalOutput();
@@ -162,6 +175,7 @@ void consequence_game()
 
   screen.Loop(renderer);
 }
+}
 
 struct Color
 {
@@ -177,13 +191,12 @@ struct Bitmap : ftxui::Node
     : width_(width), height_(height)
   {}
 
-  Color &at(std::size_t cur_x, std::size_t cur_y) { return pixels.at(width_ * cur_y + cur_x); }
+  Color &at(std::size_t cur_x, std::size_t cur_y) { return pixels.at((width_ * cur_y) + cur_x); }
 
   void ComputeRequirement() override
   {
-    requirement_ = ftxui::Requirement{
-      .min_x = static_cast<int>(width_), .min_y = static_cast<int>(height_ / 2), .selected_box{ 0, 0, 0, 0 }
-    };
+    requirement_.min_x = static_cast<int>(width_);
+    requirement_.min_y = static_cast<int>(height_ / 2);
   }
 
   void Render(ftxui::Screen &screen) override
@@ -193,7 +206,7 @@ struct Bitmap : ftxui::Node
         auto &pixel = screen.PixelAt(box_.x_min + static_cast<int>(cur_x), box_.y_min + static_cast<int>(cur_y));
         pixel.character = "▄";
         const auto &top_color = at(cur_x, cur_y * 2);
-        const auto &bottom_color = at(cur_x, cur_y * 2 + 1);
+        const auto &bottom_color = at(cur_x, (cur_y * 2) + 1);
         pixel.background_color = ftxui::Color{ top_color.R.get(), top_color.G.get(), top_color.B.get() };
         pixel.foreground_color = ftxui::Color{ bottom_color.R.get(), bottom_color.G.get(), bottom_color.B.get() };
       }
@@ -213,6 +226,7 @@ struct Bitmap : ftxui::Node
   std::vector<Color> pixels = std::vector<Color>(width_ * height_, Color{});
 };
 
+namespace {
 void game_iteration_canvas()
 {
   // this should probably have a `bitmap` helper function that does what cur_you expect
@@ -257,6 +271,8 @@ void game_iteration_canvas()
     case 2:
       small_bm_pixel.B += 11;// NOLINT Magic Number
       break;
+    default: // literally impossible
+      std::unreachable();
     }
 
 
@@ -308,6 +324,7 @@ void game_iteration_canvas()
   refresh_ui_continue = false;
   refresh_ui.join();
 }
+}
 
 // NOLINTNEXTLINE(bugprone-exception-escape)
 int main(int argc, const char **argv)