Skip to content

Commit ec01c73

Browse files
leftibotclaude
andauthored
Fix #76: -Wsign-conversion is redundant (#149)
* Fix #76: Remove redundant -Wsign-conversion from CLANG_WARNINGS -Wconversion already implies -Wsign-conversion for both GCC and Clang, making the explicit -Wsign-conversion flag redundant in the CLANG_WARNINGS list. Since GCC_WARNINGS inherits from CLANG_WARNINGS, this removal applies to both compilers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c61d47f commit ec01c73

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

cmake/CompilerWarnings.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ function(
5151
-Woverloaded-virtual # warn if you overload (not override) a virtual function
5252
-Wpedantic # warn if non-standard C++ is used
5353
-Wconversion # warn on type conversions that may lose data
54-
-Wsign-conversion # warn on sign conversions
5554
-Wnull-dereference # warn if a null dereference is detected
5655
-Wdouble-promotion # warn if float is implicit promoted to double
5756
-Wformat=2 # warn on security issues around functions that format output (ie printf)

0 commit comments

Comments
 (0)