Skip to content

[WIP] Issue #134 — ENABLE_DEVELOPER_MODE is still relevant? #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lefticus merged 2 commits into from
Apr 12, 2026
Merged

[WIP] Issue #134 — ENABLE_DEVELOPER_MODE is still relevant? #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f0d76
Fix #134: Remove dead ENABLE_DEVELOPER_MODE variable
leftibot Apr 11, 2026
cde9dbb
Address review: remove ENABLE_DEVELOPER_MODE guard from ProjectOption…
leftibot Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 10 additions & 36 deletions CMakePresets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,51 +57,25 @@
}
},
{
"name": "windows-msvc-debug-developer-mode",
"displayName": "msvc Debug (Developer Mode)",
"name": "windows-msvc-debug",
"displayName": "msvc Debug",
"description": "Target Windows with the msvc compiler, debug build type",
"inherits": "conf-windows-common",
"cacheVariables": {
"CMAKE_C_COMPILER": "cl",
"CMAKE_CXX_COMPILER": "cl",
"CMAKE_BUILD_TYPE": "Debug",
"ENABLE_DEVELOPER_MODE": "ON"
}
},
{
"name": "windows-msvc-release-developer-mode",
"displayName": "msvc Release (Developer Mode)",
"description": "Target Windows with the msvc compiler, release build type",
"inherits": "conf-windows-common",
"cacheVariables": {
"CMAKE_C_COMPILER": "cl",
"CMAKE_CXX_COMPILER": "cl",
"CMAKE_BUILD_TYPE": "RelWithDebInfo",
"ENABLE_DEVELOPER_MODE": "ON"
}
},
{
"name": "windows-msvc-debug-user-mode",
"displayName": "msvc Debug (User Mode)",
"description": "Target Windows with the msvc compiler, debug build type",
"inherits": "conf-windows-common",
"cacheVariables": {
"CMAKE_C_COMPILER": "cl",
"CMAKE_CXX_COMPILER": "cl",
"CMAKE_BUILD_TYPE": "Debug",
"ENABLE_DEVELOPER_MODE": "OFF"
"CMAKE_BUILD_TYPE": "Debug"
}
},
{
"name": "windows-msvc-release-user-mode",
"displayName": "msvc Release (User Mode)",
"name": "windows-msvc-release",
"displayName": "msvc Release",
"description": "Target Windows with the msvc compiler, release build type",
"inherits": "conf-windows-common",
"cacheVariables": {
"CMAKE_C_COMPILER": "cl",
"CMAKE_CXX_COMPILER": "cl",
"CMAKE_BUILD_TYPE": "RelWithDebInfo",
"ENABLE_DEVELOPER_MODE": "OFF"
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
{
Expand Down Expand Up @@ -195,18 +169,18 @@
}
},
{
"name": "test-windows-msvc-debug-developer-mode",
"name": "test-windows-msvc-debug",
"displayName": "Strict",
"description": "Enable output and stop on failure",
"inherits": "test-common",
"configurePreset": "windows-msvc-debug-developer-mode"
"configurePreset": "windows-msvc-debug"
},
{
"name": "test-windows-msvc-release-developer-mode",
"name": "test-windows-msvc-release",
"displayName": "Strict",
"description": "Enable output and stop on failure",
"inherits": "test-common",
"configurePreset": "windows-msvc-release-developer-mode"
"configurePreset": "windows-msvc-release"
},
{
"name": "test-windows-clang-debug",
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

This is a C++ Best Practices GitHub template for getting up and running with C++ quickly.

By default (collectively known as `ENABLE_DEVELOPER_MODE`)
By default (when building as the top-level project)

* Address Sanitizer and Undefined Behavior Sanitizer enabled where possible
* Warnings as errors
Expand Down
Loading