chore: remove bandit from pre-commit, increase coverage to 100%

- Remove Bandit from pre-commit hooks (kept in CI security job only)
- Add test for check_install_arch() amd64 branch
- Add test for clang_tools_binary_url() non-macOS platform branch
- Add test for install_dir_name() Linux default directory
- Add test for create_sym_link() mkdir when directory doesn't exist
- Add tests for _wheel_install() success and failure paths
- Add test for _handle_binary with zeroed-out version (0.0.0)

Production code coverage: clang_tools/*.py -> 100%

Author: shenxianpeng

.pre-commit-config.yaml

@@ -21,12 +21,6 @@ repos:
     hooks:
       - id: ruff-check
       - id: ruff-format
-  - repo: https://github.com/PyCQA/bandit
-    rev: 1.8.4
-    hooks:
-      - id: bandit
-        args: ["-c", "pyproject.toml"]
-        additional_dependencies: ["bandit[toml]"]
   # - repo: local
   #   hooks:
   #     - id: pytest

tests/test_install.py

@@ -335,3 +335,38 @@ def test_install_clang_tools_path_not_in_env(
 
     result = capsys.readouterr()
     assert "directory is not in your environment variable PATH" in result.out
+
+
+def test_clang_tools_binary_url_non_macos(monkeypatch: pytest.MonkeyPatch):
+    """Test clang_tools_binary_url with a non-macOS platform string."""
+    monkeypatch.setattr("clang_tools.install.install_os", "linux")
+    monkeypatch.setattr("clang_tools.install.install_arch", "amd64")
+    url = clang_tools_binary_url("clang-format", "12")
+    assert "linux-amd64" in url
+
+
+def test_install_dir_name_linux_default(monkeypatch: pytest.MonkeyPatch):
+    """Test install_dir_name returns ~/.local/bin/ on Linux when no dir given."""
+    monkeypatch.setattr("clang_tools.install.install_os", "linux")
+    result = install_dir_name("")
+    assert result == os.path.expanduser("~/.local/bin/")
+
+
+def test_create_sym_link_nonexistent_dir(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+):
+    """Test create_sym_link creates the install directory if it doesn't exist."""
+    monkeypatch.chdir(str(tmp_path))
+    tool_name, version = "clang-tool", "1"
+    # Create the target binary in tmp_path
+    target = tmp_path / f"{tool_name}-{version}{suffix}"
+    target.write_bytes(b"some binary data")
+
+    # Use a nested subdir that does not exist yet
+    new_dir = tmp_path / "new_install_dir"
+    assert not new_dir.exists()
+
+    assert create_sym_link(tool_name, version, str(new_dir), False, target=target)
+    assert new_dir.exists()
+    link = new_dir / f"{tool_name}{suffix}"
+    assert link.is_symlink()

tests/test_main.py

@@ -375,6 +375,39 @@ def test_main_install_auto_detect_invalid_version(
 # ---- ``uninstall`` subcommand -----------------------------------------
 
 
+def test_wheel_install_success(monkeypatch: pytest.MonkeyPatch, capsys):
+    """Test _wheel_install directly with a mocked resolve_install (success)."""
+    from clang_tools.main import _wheel_install
+
+    monkeypatch.setattr(
+        "cpp_linter_hooks.util.resolve_install", lambda t, v: f"/fake/{t}"
+    )
+    assert _wheel_install(["clang-format"], "18") == 0
+    assert "installed at:" in capsys.readouterr().out
+
+
+def test_wheel_install_failure(monkeypatch: pytest.MonkeyPatch, capsys):
+    """Test _wheel_install directly with a failing resolve_install."""
+    from clang_tools.main import _wheel_install
+
+    monkeypatch.setattr("cpp_linter_hooks.util.resolve_install", lambda t, v: None)
+    assert _wheel_install(["clang-tidy"], "21") == 1
+    assert "Failed to install" in capsys.readouterr().err
+
+
+def test_main_install_binary_bad_semver(monkeypatch: pytest.MonkeyPatch, capsys):
+    """``--binary`` with a version-like but zeroed-out version (e.g. 0.0.0)."""
+    monkeypatch.setattr(
+        sys,
+        "argv",
+        ["clang-tools", "install", "0.0.0", "--binary"],
+    )
+    exit_code = main()
+    result = capsys.readouterr()
+    assert exit_code == 1
+    assert "not a semantic" in result.err
+
+
 def test_main_uninstall_subcommand(monkeypatch: pytest.MonkeyPatch, tmp_path, capsys):
     """``clang-tools uninstall 12`` removes installed tools."""
     tool_name = "clang-format"

tests/test_util.py

@@ -157,3 +157,9 @@ def test_check_install_os_unsupported(monkeypatch: pytest.MonkeyPatch):
     monkeypatch.setattr("platform.system", lambda: "SunOS")
     with pytest.raises(SystemExit, match="sunos is not currently supported"):
         check_install_os()
+
+
+def test_check_install_arch_amd64(monkeypatch: pytest.MonkeyPatch):
+    """Tests check_install_arch returns 'amd64' for x86_64 machines."""
+    monkeypatch.setattr("platform.machine", lambda: "x86_64")
+    assert check_install_arch() == "amd64"