fix: address review issues for unified CLI PR

- Fix uninstall_clang_tools argument order (version/tools were swapped)
- Update CI workflow to use new subcommand syntax (clang-tools install, not --install)
- Fix type annotations: tools: str → list[str] in install.py
- Strengthen uninstall test to assert actual filesystem removal

Author: shenxianpeng

.github/workflows/test.yml

@@ -96,7 +96,7 @@ jobs:
         run: pip install --no-cache-dir dist/*.whl
 
       - name: Install clang-tools binaries
-        run: clang-tools --install ${{ matrix.version }} --tool clang-format clang-tidy clang-query clang-apply-replacements
+        run: clang-tools install ${{ matrix.version }} --tool clang-format clang-tidy clang-query clang-apply-replacements
 
       - name: Show path of clang-tools binaries
         shell: bash
@@ -145,7 +145,7 @@ jobs:
         shell: bash
         run: |
           set -e
-          clang-tools-wheel --tool clang-format --version ${{ matrix.version }}
+          clang-tools install clang-format --wheel --version ${{ matrix.version }}
 
           echo "Checking clang-format versions..."
           clang-format --version
@@ -167,7 +167,7 @@ jobs:
         shell: bash
         run: |
           set -e
-          clang-tools-wheel --tool clang-tidy --version ${{ matrix.version }}
+          clang-tools install clang-tidy --wheel --version ${{ matrix.version }}
 
           echo "Checking clang-tidy versions..."
           clang-tidy --version

clang_tools/install.py

@@ -247,7 +247,7 @@ def uninstall_tool(tool_name: str, version: str, directory: str):
         symlink.unlink()
 
 
-def uninstall_clang_tools(tools: str, version: str, directory: str):
+def uninstall_clang_tools(tools: list[str], version: str, directory: str):
     """Uninstall a clang tool of a given version.
 
     :param version: The version of the clang-tools to remove.
@@ -261,7 +261,7 @@ def uninstall_clang_tools(tools: str, version: str, directory: str):
 
 
 def install_clang_tools(
-    version: Version, tools: str, directory: str, overwrite: bool, no_progress_bar: bool
+    version: Version, tools: list[str], directory: str, overwrite: bool, no_progress_bar: bool
 ) -> None:
     """Wraps functions used to individually install tools.
 

clang_tools/main.py

@@ -258,7 +258,7 @@ def main() -> int:
         return 0
 
     if args.command == "uninstall":
-        uninstall_clang_tools(args.version, args.tool, args.directory)
+        uninstall_clang_tools(args.tool, args.version, args.directory)
         return 0
 
     if args.command == "install":

tests/test_main.py

@@ -400,3 +400,4 @@ def test_main_uninstall_subcommand(monkeypatch: pytest.MonkeyPatch, tmp_path, ca
     result = capsys.readouterr()
     assert exit_code == 0
     assert "Uninstalling" in result.out
+    assert not dummy_bin.exists()