Skip to content

fix: restore trailing wildcard in artifact upload glob for Windows .exe binaries#123

Merged
shenxianpeng merged 1 commit into
masterfrom
fix/windows-artifact-upload-glob
Jul 1, 2026
Merged

fix: restore trailing wildcard in artifact upload glob for Windows .exe binaries#123
shenxianpeng merged 1 commit into
masterfrom
fix/windows-artifact-upload-glob

Conversation

@shenxianpeng

@shenxianpeng shenxianpeng commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

Fix a glob pattern bug in the Upload artifacts step of build.yml that caused all Windows binaries to be missing from the published release.

Root Cause

Commit ae20618 accidentally dropped the trailing * from the clang-* and llvm-* glob patterns when adding the SHA512SUMS upload path.

Before (broken) vs After (fixed):

Pattern Effect
clang-*-${{ env.suffix }}* ✅ Linux/macOS matches bare files, Windows matches .exe files
clang-*-${{ env.suffix }} ❌ Cannot match .exe suffix on Windows, causing all Windows binaries to be omitted

Release 2026.06.29-ae206185 ended up with 374 assets total (186 Linux + 186 macOS), and zero Windows assets.

Fix

Restore the trailing * to both glob patterns:

  • clang-*-${{ env.suffix }}clang-*-${{ env.suffix }}*
  • llvm-*-${{ env.suffix }}llvm-*-${{ env.suffix }}*

Next Steps

After merging this PR, re-trigger a CI build to produce a new release that includes Windows binaries. Then update the binary_tag in clang-tools-pip to point to the new release.

…xe binaries

The Upload artifacts step in build.yml uses glob patterns to find built
binaries. Linux and macOS produce plain files (e.g.
clang-format-13_linux-amd64), but Windows appends .exe. The patterns
originally ended with * (e.g. clang-*-${{ env.suffix }}*) to cover both
cases, but commit ae20618 accidentally dropped the trailing * when
adding the SHA512SUMS entry.

Without the trailing *, clang-*-13_windows-amd64 fails to match
clang-format-13_windows-amd64.exe, so no Windows binaries are uploaded
as build artifacts and consequently none appear in the GitHub Release.
This caused the 2026.06.29-ae206185 release to ship 374 assets (Linux
and macOS only) with zero Windows binaries.
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@shenxianpeng, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de8ebb34-10b7-45da-b654-2b07d44e89e2

📥 Commits

Reviewing files that changed from the base of the PR and between 78520d6 and 808f12d.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shenxianpeng shenxianpeng added the bug Something isn't working label Jul 1, 2026
@shenxianpeng shenxianpeng merged commit e6fa8f6 into master Jul 1, 2026
29 of 75 checks passed
@shenxianpeng shenxianpeng deleted the fix/windows-artifact-upload-glob branch July 1, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant