fix: restore trailing wildcard in artifact upload glob for Windows .exe binaries#123
Conversation
…xe binaries
The Upload artifacts step in build.yml uses glob patterns to find built
binaries. Linux and macOS produce plain files (e.g.
clang-format-13_linux-amd64), but Windows appends .exe. The patterns
originally ended with * (e.g. clang-*-${{ env.suffix }}*) to cover both
cases, but commit ae20618 accidentally dropped the trailing * when
adding the SHA512SUMS entry.
Without the trailing *, clang-*-13_windows-amd64 fails to match
clang-format-13_windows-amd64.exe, so no Windows binaries are uploaded
as build artifacts and consequently none appear in the GitHub Release.
This caused the 2026.06.29-ae206185 release to ship 374 assets (Linux
and macOS only) with zero Windows binaries.
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fix a glob pattern bug in the
Upload artifactsstep ofbuild.ymlthat caused all Windows binaries to be missing from the published release.Root Cause
Commit
ae20618accidentally dropped the trailing*from theclang-*andllvm-*glob patterns when adding theSHA512SUMSupload path.Before (broken) vs After (fixed):
clang-*-${{ env.suffix }}*.exefilesclang-*-${{ env.suffix }}.exesuffix on Windows, causing all Windows binaries to be omittedRelease
2026.06.29-ae206185ended up with 374 assets total (186 Linux + 186 macOS), and zero Windows assets.Fix
Restore the trailing
*to both glob patterns:clang-*-${{ env.suffix }}→clang-*-${{ env.suffix }}*llvm-*-${{ env.suffix }}→llvm-*-${{ env.suffix }}*Next Steps
After merging this PR, re-trigger a CI build to produce a new release that includes Windows binaries. Then update the
binary_taginclang-tools-pipto point to the new release.