fix: update pre-commit configuration and improve argument formatting in clang_tidy

Author: shenxianpeng

.pre-commit-config.yaml

@@ -1,3 +1,6 @@
+ci:
+  autofix_prs: true
+
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v6.0.0
@@ -10,7 +13,7 @@ repos:
       - id: check-toml
       - id: requirements-txt-fixer
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.14.2
+    rev: v0.15.8
     hooks:
       # Run the linter.
       - id: ruff-check

cpp_linter_hooks/clang_tidy.py

@@ -11,7 +11,9 @@
 parser = ArgumentParser()
 parser.add_argument("--version", default=DEFAULT_CLANG_TIDY_VERSION)
 parser.add_argument("--compile-commands", default=None, dest="compile_commands")
-parser.add_argument("--no-compile-commands", action="store_true", dest="no_compile_commands")
+parser.add_argument(
+    "--no-compile-commands", action="store_true", dest="no_compile_commands"
+)
 parser.add_argument("-v", "--verbose", action="store_true")
 
 
@@ -51,7 +53,9 @@ def run_clang_tidy(args=None) -> Tuple[int, str]:
 
     if compile_db_path:
         if hook_args.verbose:
-            print(f"Using compile_commands.json from: {compile_db_path}", file=sys.stderr)
+            print(
+                f"Using compile_commands.json from: {compile_db_path}", file=sys.stderr
+            )
         other_args = ["-p", compile_db_path] + other_args
 
     command = ["clang-tidy"] + other_args

tests/test_clang_tidy.py

@@ -72,8 +72,12 @@ def test_compile_commands_explicit(tmp_path):
     db_dir = tmp_path / "build"
     db_dir.mkdir()
     (db_dir / "compile_commands.json").write_text("[]")
-    with patch("cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN) as mock_run, \
-            patch("cpp_linter_hooks.clang_tidy.resolve_install"):
+    with (
+        patch(
+            "cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN
+        ) as mock_run,
+        patch("cpp_linter_hooks.clang_tidy.resolve_install"),
+    ):
         run_clang_tidy([f"--compile-commands={db_dir}", "dummy.cpp"])
     cmd = mock_run.call_args[0][0]
     assert "-p" in cmd
@@ -85,8 +89,12 @@ def test_compile_commands_auto_detect(tmp_path, monkeypatch):
     build_dir = tmp_path / "build"
     build_dir.mkdir()
     (build_dir / "compile_commands.json").write_text("[]")
-    with patch("cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN) as mock_run, \
-            patch("cpp_linter_hooks.clang_tidy.resolve_install"):
+    with (
+        patch(
+            "cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN
+        ) as mock_run,
+        patch("cpp_linter_hooks.clang_tidy.resolve_install"),
+    ):
         run_clang_tidy(["dummy.cpp"])
     cmd = mock_run.call_args[0][0]
     assert "-p" in cmd
@@ -99,8 +107,12 @@ def test_compile_commands_auto_detect_fallback(tmp_path, monkeypatch):
     out_dir = tmp_path / "out"
     out_dir.mkdir()
     (out_dir / "compile_commands.json").write_text("[]")
-    with patch("cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN) as mock_run, \
-            patch("cpp_linter_hooks.clang_tidy.resolve_install"):
+    with (
+        patch(
+            "cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN
+        ) as mock_run,
+        patch("cpp_linter_hooks.clang_tidy.resolve_install"),
+    ):
         run_clang_tidy(["dummy.cpp"])
     cmd = mock_run.call_args[0][0]
     assert "-p" in cmd
@@ -109,8 +121,12 @@ def test_compile_commands_auto_detect_fallback(tmp_path, monkeypatch):
 
 def test_compile_commands_none(tmp_path, monkeypatch):
     monkeypatch.chdir(tmp_path)
-    with patch("cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN) as mock_run, \
-            patch("cpp_linter_hooks.clang_tidy.resolve_install"):
+    with (
+        patch(
+            "cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN
+        ) as mock_run,
+        patch("cpp_linter_hooks.clang_tidy.resolve_install"),
+    ):
         run_clang_tidy(["dummy.cpp"])
     cmd = mock_run.call_args[0][0]
     assert "-p" not in cmd
@@ -122,8 +138,12 @@ def test_compile_commands_conflict_guard(tmp_path, monkeypatch):
     build_dir = tmp_path / "build"
     build_dir.mkdir()
     (build_dir / "compile_commands.json").write_text("[]")
-    with patch("cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN) as mock_run, \
-            patch("cpp_linter_hooks.clang_tidy.resolve_install"):
+    with (
+        patch(
+            "cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN
+        ) as mock_run,
+        patch("cpp_linter_hooks.clang_tidy.resolve_install"),
+    ):
         run_clang_tidy(["-p", "./custom", "dummy.cpp"])
     cmd = mock_run.call_args[0][0]
     assert cmd.count("-p") == 1
@@ -136,8 +156,12 @@ def test_compile_commands_no_flag(tmp_path, monkeypatch):
     build_dir = tmp_path / "build"
     build_dir.mkdir()
     (build_dir / "compile_commands.json").write_text("[]")
-    with patch("cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN) as mock_run, \
-            patch("cpp_linter_hooks.clang_tidy.resolve_install"):
+    with (
+        patch(
+            "cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN
+        ) as mock_run,
+        patch("cpp_linter_hooks.clang_tidy.resolve_install"),
+    ):
         run_clang_tidy(["--no-compile-commands", "dummy.cpp"])
     cmd = mock_run.call_args[0][0]
     assert "-p" not in cmd
@@ -165,8 +189,12 @@ def test_compile_commands_explicit_with_p_conflict(tmp_path, capsys):
     db_dir = tmp_path / "build"
     db_dir.mkdir()
     (db_dir / "compile_commands.json").write_text("[]")
-    with patch("cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN) as mock_run, \
-            patch("cpp_linter_hooks.clang_tidy.resolve_install"):
+    with (
+        patch(
+            "cpp_linter_hooks.clang_tidy.subprocess.run", return_value=_MOCK_RUN
+        ) as mock_run,
+        patch("cpp_linter_hooks.clang_tidy.resolve_install"),
+    ):
         run_clang_tidy([f"--compile-commands={db_dir}", "-p", "./other", "dummy.cpp"])
     captured = capsys.readouterr()
     assert "Warning" in captured.err