fix: stale workflow permissions mismatch with reusable workflow#107
Merged
shenxianpeng merged 2 commits intomainfrom Sep 11, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 3 3
Lines 145 145
=======================================
Hits 137 137
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: shenxianpeng <3353385+shenxianpeng@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Fix stale workflow permissions for reusable workflow compatibility
Fix stale workflow permissions mismatch with reusable workflow
Sep 11, 2025
shenxianpeng
approved these changes
Sep 11, 2025
Member
|
After this PR merged, the rerun still failed https://github.com/cpp-linter/cpp-linter-hooks/actions/runs/17632374669 Maybe it needs a new run? cc @2bndy5 |
Contributor
|
Yep. A rerun will use the old workflow file before this was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The stale workflow was failing due to a permissions mismatch with the reusable workflow at
cpp-linter/.github/.github/workflows/stale.yml@main. The error indicated that the nested job 'stale' was requestingcontents: read, pull-requests: writepermissions, but was only allowedcontents: none, pull-requests: none.Problem
The workflow had workflow-level permissions set to only
issues: write, but the reusable workflow requires additional permissions (contents: readandpull-requests: write) that weren't being granted to the nested job.Solution
Updated the stale workflow to follow least privilege security practices:
permissions: {}(empty/minimal)contents: read- required by the reusable workflowissues: write- retained from original configurationpull-requests: write- required by the reusable workflowThis approach ensures that only the specific job that needs these permissions receives them, rather than granting them at the workflow level, which follows GitHub's security best practices.
Changes
.github/workflows/stale.ymlto use job-level permissions instead of workflow-level permissionsThe workflow should now run successfully without permission errors.
This pull request was created as a result of the following prompt from Copilot chat.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.