chore: add pragma: no cover to ignore test#76
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 89.61% 92.00% +2.38%
==========================================
Files 3 3
Lines 77 75 -2
==========================================
Hits 69 69
+ Misses 8 6 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WalkthroughCoverage exclusion comments were added to specific print statements in the Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
cpp_linter_hooks/clang_tidy.py (1)
34-36: Consider routing diagnostic output tostderr(or usinglogging) instead ofstdout.
print(output) # pragma: no coverwrites diagnostics to stdout, which can mix with the actual clang-tidy output that calling tools may parse. Forwarding tosys.stderr(or adopting theloggingmodule) keeps channels separated and avoids surprising consumers, while the# pragma: no coverannotation can stay unchanged.@@ - if retval != 0: - print(output) # pragma: no cover + if retval != 0: + import sys # local import to avoid polluting the module namespace + print(output, file=sys.stderr) # pragma: no covercpp_linter_hooks/clang_format.py (1)
34-37: Mirror stderr routing for consistency with other hooks.As with the clang-tidy hook, sending non-zero-return diagnostics to
stderravoids polluting regular output and aligns with typical CLI conventions. The coverage-exclusion comment can remain.@@ - if retval != 0: - print(output) # pragma: no cover + if retval != 0: + import sys # local import keeps the public surface unchanged + print(output, file=sys.stderr) # pragma: no cover
1 participant
Summary by CodeRabbit