Skip to content

Commit 45cfdef

Browse files
committed
disable ppc64le and s390x python builds
compiling aws-ls-sys on these targets are way too flaky, even for me.
1 parent 5d41501 commit 45cfdef

2 files changed

Lines changed: 24 additions & 24 deletions

File tree

.github/workflows/python-packaging.yml

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ jobs:
6565
needs: [seed-build-script]
6666
runs-on: ${{ matrix.platform.runner }}
6767
strategy:
68+
fail-fast: false
6869
matrix:
6970
platform:
7071
- runner: ubuntu-latest
@@ -75,10 +76,13 @@ jobs:
7576
target: aarch64
7677
- runner: ubuntu-latest
7778
target: armv7
78-
- runner: ubuntu-latest
79-
target: s390x
80-
- runner: ubuntu-latest
81-
target: ppc64le
79+
# These targets currently fail because the docker containers used for building manylinux wheels
80+
# use a known-bad C compiler version; aws-lc-sys refuses to build with the bad compiler:
81+
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189
82+
# - runner: ubuntu-latest
83+
# target: s390x
84+
# - runner: ubuntu-latest
85+
# target: ppc64le
8286
steps:
8387
- uses: actions/checkout@v6
8488
with:
@@ -98,28 +102,22 @@ jobs:
98102
# Use the zig toolchain for all targets except ppc64le.
99103
# Note, this is meant to avoid build errors in aws-lc-sys crate, which compiles C code.
100104
args: >-
101-
--release --out dist --find-interpreter
102-
${{ matrix.platform.target != 'ppc64le' && '--zig' || ''}}
105+
--release --out dist --find-interpreter --zig
103106
# avoid cache-poisoning potential for actually distributed builds
104107
sccache: ${{ startsWith(github.ref, 'refs/tags') && 'false' || 'true' }}
105-
manylinux: auto
106-
# here we either install the ppc64le compiler/toolchain or install zig on all others
107-
before-script-linux: |
108-
case "${{ matrix.platform.target }}" in
109-
ppc64le)
110-
apt-get update
111-
apt-get install -y \
112-
pkg-config \
113-
gcc-powerpc64le-linux-gnu \
114-
g++-powerpc64le-linux-gnu \
115-
binutils-powerpc64le-linux-gnu \
116-
libc6-dev-ppc64el-cross
117-
;;
118-
*)
119-
# spell-checker: disable-next-line
120-
pip install ziglang
121-
;;
122-
esac
108+
manylinux: 'auto'
109+
# before-script-linux: |
110+
# case "${{ matrix.platform.target }}" in
111+
# ppc64le)
112+
# apt-get update
113+
# apt-get install -y \
114+
# pkg-config \
115+
# gcc-powerpc64le-linux-gnu \
116+
# g++-powerpc64le-linux-gnu \
117+
# binutils-powerpc64le-linux-gnu \
118+
# libc6-dev-ppc64el-cross
119+
# ;;
120+
# esac
123121
- name: Upload wheels
124122
uses: actions/upload-artifact@v7
125123
with:

.github/workflows/run-dev-tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ jobs:
4848
if-no-files-found: error
4949

5050
test:
51+
needs: [seed-build-script]
5152
strategy:
5253
fail-fast: false
5354
matrix:
@@ -167,3 +168,4 @@ jobs:
167168
token: ${{secrets.CODECOV_TOKEN}}
168169
files: lcov.info
169170
fail_ci_if_error: true # optional (default = false)
171+
use_pypi: true # workaround unexpected GPG key changes (temporarily)

0 commit comments

Comments
 (0)