revise check about diff_base being a str or int.

2bndy5 · 2bndy5 · commit 67bc4fe2f68b · 2026-02-05T04:19:42.000-08:00
Should be more performant now.
diff --git a/cpp-linter/src/git.rs b/cpp-linter/src/git.rs
@@ -39,10 +39,11 @@ fn get_sha<'d, T: Display>(
 ) -> Result<git2::Object<'d>, Error> {
     match depth {
         Some(base) => {
-            if base.to_string().parse::<u32>().is_ok() {
+            let base = base.to_string();
+            if base.chars().all(|c| c.is_digit(10)) {
                 repo.revparse_single(format!("HEAD~{}", base).as_str())
             } else {
-                repo.revparse_single(format!("{base}").as_str())
+                repo.revparse_single(base.as_str())
             }
         }
         None => repo.revparse_single("HEAD"),

Original file line number	Diff line number	Diff line change
`@@ -39,10 +39,11 @@ fn get_sha<'d, T: Display>(`
`39`	`39`	`) -> Result<git2::Object<'d>, Error> {`
`40`	`40`	`match depth {`
`41`	`41`	`Some(base) => {`
`42`		`- if base.to_string().parse::<u32>().is_ok() {`
	`42`	`+ let base = base.to_string();`
	`43`	`+ if base.chars().all(\|c\| c.is_digit(10)) {`
`43`	`44`	`repo.revparse_single(format!("HEAD~{}", base).as_str())`
`44`	`45`	`} else {`
`45`		`- repo.revparse_single(format!("{base}").as_str())`
	`46`	`+ repo.revparse_single(base.as_str())`
`46`	`47`	`}`
`47`	`48`	`}`
`48`	`49`	`None => repo.revparse_single("HEAD"),`