Commit 89d9a7e
authored
fix: do not fail on check for tool presence (via package managers) (#345)
- ref: #342
I added some debug logs and ran the `clang-tools` binary in a docker
container. I found that the `apt` package manager support was failing
because the check for any existing clang tool failed when the tool was
not installed.
I converted the check for a clang tool's presence into a soft check.
Meaning, if it somehow fails then just fall back to installing the clang
tool as if doing a fresh/normal install.
> [!note]
> The container I used seemed to be too new; the LLVM install script
does not yet support Ubuntu "resolute". But at least the `clang-tools`
binary was able to fall back to static binaries. Plus, the debug and
error logs are explanatory enough.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Improved package installation reliability by gracefully handling
detection failures and proceeding with installation attempts when
needed.
* **Chores**
* Enhanced diagnostic logging for package installation operations to aid
troubleshooting.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->1 parent b213c8a commit 89d9a7e
2 files changed
Lines changed: 24 additions & 10 deletions
Lines changed: 10 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| |||
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
130 | 135 | | |
131 | 136 | | |
132 | 137 | | |
133 | 138 | | |
134 | 139 | | |
135 | 140 | | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
136 | 146 | | |
137 | 147 | | |
138 | 148 | | |
| |||
145 | 155 | | |
146 | 156 | | |
147 | 157 | | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
148 | 162 | | |
149 | 163 | | |
150 | 164 | | |
| |||
0 commit comments