explicitly close the tmp file before renaming

run CI tests on installer crate too

Author: 2bndy5

.github/workflows/run-dev-tests.yml

@@ -5,13 +5,15 @@ on:
     branches: [main]
     paths:
       - cpp-linter/**
+      - clang-installer/**
       - Cargo.toml
       - Cargo.lock
       - .github/workflows/run-dev-tests.yml
   pull_request:
     branches: [main]
     paths:
       - cpp-linter/**
+      - clang-installer/**
       - Cargo.toml
       - Cargo.lock
       - .github/workflows/run-dev-tests.yml

clang-installer/src/downloader/mod.rs

@@ -88,6 +88,7 @@ async fn download(url: &Url, cache_path: &Path, timeout: u64) -> Result<(), Down
     progress_bar.finish()?;
     tmp_file.flush()?;
     tmp_file.set_modified(SystemTime::now())?;
+    drop(tmp_file); // ensure the file is closed before renaming
     fs::rename(tmp_file_path, cache_path)
         .map_err(|e| DownloadError::TempFile("renaming temporary file after download", e))?;
     Ok(())