fix: refactor for unsupported static binary platforms (#356)

2bndy5 · web-flow · commit b6ff9bdd4c09 · 2026-06-12T20:31:19.000-07:00
Previous builds for unsupported platforms issued a bunch of warnings
because of unused code.

This refactors the clang-tools-manager/src/downloader/static_dist.rs
module to only compile code that is actually used per the compile
target.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -26,22 +26,8 @@ concurrency:
 
 jobs:
   seed-build-script:
-    runs-on: ubuntu-latest
     name: Pre-seed static binaries' versions
-    steps:
-      - env:
-          GITHUB_TOKEN: ${{ github.token }}
-        run: >-
-          gh release download
-          -R cpp-linter/clang-tools-static-binaries
-          --pattern versions.json
-          --output versions.json
-      - name: Upload versions.json
-        uses: actions/upload-artifact@v7
-        with:
-          name: static-binary-versions
-          path: versions.json
-          if-no-files-found: error
+    uses: ./.github/workflows/pre-seed-versions.yml
 
   build-bin:
     needs: [seed-build-script]
@@ -83,7 +69,7 @@ jobs:
         if: steps.cache.outputs.cache-hit != 'true' || steps.validate.outputs.cache-valid == 'false'
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
       - run: cargo build --bin cpp-linter --features bin --release
         if: steps.cache.outputs.cache-hit != 'true' || steps.validate.outputs.cache-valid == 'false'
diff --git a/.github/workflows/binary-builds.yml b/.github/workflows/binary-builds.yml
@@ -35,22 +35,8 @@ concurrency:
 
 jobs:
   seed-build-script:
-    runs-on: ubuntu-latest
     name: Pre-seed static binaries' versions
-    steps:
-      - env:
-          GITHUB_TOKEN: ${{ github.token }}
-        run: >-
-          gh release download
-          -R cpp-linter/clang-tools-static-binaries
-          --pattern versions.json
-          --output versions.json
-      - name: Upload versions.json
-        uses: actions/upload-artifact@v7
-        with:
-          name: static-binary-versions
-          path: versions.json
-          if-no-files-found: error
+    uses: ./.github/workflows/pre-seed-versions.yml
 
   create-assets:
     needs: [seed-build-script]
@@ -135,7 +121,7 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
 
       - name: Build
diff --git a/.github/workflows/build-docs.yml b/.github/workflows/build-docs.yml
@@ -45,22 +45,8 @@ jobs:
       - run: cargo fetch
 
   seed-build-script:
-    runs-on: ubuntu-latest
     name: Pre-seed static binaries' versions
-    steps:
-      - env:
-          GITHUB_TOKEN: ${{ github.token }}
-        run: >-
-          gh release download
-          -R cpp-linter/clang-tools-static-binaries
-          --pattern versions.json
-          --output versions.json
-      - name: Upload versions.json
-        uses: actions/upload-artifact@v7
-        with:
-          name: static-binary-versions
-          path: versions.json
-          if-no-files-found: error
+    uses: ./.github/workflows/pre-seed-versions.yml
 
   build-mkdocs:
     runs-on: ubuntu-latest
@@ -87,7 +73,7 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
       - name: Build docs
         run: nur docs --build
@@ -123,7 +109,7 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
       - run: nur docs rs
       - name: upload rustdoc build as artifact
diff --git a/.github/workflows/node-js-packaging.yml b/.github/workflows/node-js-packaging.yml
@@ -39,22 +39,8 @@ concurrency:
 
 jobs:
   seed-build-script:
-    runs-on: ubuntu-latest
     name: Pre-seed static binaries' versions
-    steps:
-      - env:
-          GITHUB_TOKEN: ${{ github.token }}
-        run: >-
-          gh release download
-          -R cpp-linter/clang-tools-static-binaries
-          --pattern versions.json
-          --output versions.json
-      - name: Upload versions.json
-        uses: actions/upload-artifact@v7
-        with:
-          name: static-binary-versions
-          path: versions.json
-          if-no-files-found: error
+    uses: ./.github/workflows/pre-seed-versions.yml
 
   build:
     needs: [seed-build-script]
@@ -143,7 +129,7 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
       - name: Build
         run: ${{ matrix.settings.build }}
@@ -178,7 +164,7 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
       - name: Build
         shell: cpa.sh {0}
diff --git a/.github/workflows/pre-seed-versions.yml b/.github/workflows/pre-seed-versions.yml
@@ -0,0 +1,29 @@
+name: Pre-seed versions
+
+on:
+  workflow_call:
+    outputs:
+      artifact-name:
+        description: >-
+          The name of uploaded artifact containing the versions.json file.
+        value: static-binary-versions
+
+permissions: {}
+
+jobs:
+  pre-seed-versions:
+    runs-on: ubuntu-latest
+    steps:
+      - env:
+          GITHUB_TOKEN: ${{ github.token }}
+        run: >-
+          gh release download
+          -R cpp-linter/clang-tools-static-binaries
+          --pattern versions.json
+          --output versions.json
+      - name: Upload versions.json
+        uses: actions/upload-artifact@v7
+        with:
+          name: static-binary-versions
+          path: versions.json
+          if-no-files-found: error
diff --git a/.github/workflows/python-packaging.yml b/.github/workflows/python-packaging.yml
@@ -44,22 +44,8 @@ concurrency:
 
 jobs:
   seed-build-script:
-    runs-on: ubuntu-latest
     name: Pre-seed static binaries' versions
-    steps:
-      - env:
-          GITHUB_TOKEN: ${{ github.token }}
-        run: >-
-          gh release download
-          -R cpp-linter/clang-tools-static-binaries
-          --pattern versions.json
-          --output versions.json
-      - name: Upload versions.json
-        uses: actions/upload-artifact@v7
-        with:
-          name: static-binary-versions
-          path: versions.json
-          if-no-files-found: error
+    uses: ./.github/workflows/pre-seed-versions.yml
 
   linux:
     needs: [seed-build-script]
@@ -93,31 +79,18 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
       - name: Build wheels
         uses: PyO3/maturin-action@e83996d129638aa358a18fbd1dfb82f0b0fb5d3b # v1.51.0
         with:
           target: ${{ matrix.platform.target }}
-          # Use the zig toolchain for all targets except ppc64le.
-          # Note, this is meant to avoid build errors in aws-lc-sys crate, which compiles C code.
+          # Use the zig toolchain to avoid build errors in aws-lc-sys crate, which compiles C code.
           args: >-
             --release --out dist --find-interpreter --zig
           # avoid cache-poisoning potential for actually distributed builds
           sccache: ${{ startsWith(github.ref, 'refs/tags') && 'false' || 'true' }}
           manylinux: 'auto'
-          # before-script-linux: |
-          #   case "${{ matrix.platform.target }}" in
-          #     ppc64le)
-          #       apt-get update
-          #       apt-get install -y \
-          #         pkg-config \
-          #         gcc-powerpc64le-linux-gnu \
-          #         g++-powerpc64le-linux-gnu \
-          #         binutils-powerpc64le-linux-gnu \
-          #         libc6-dev-ppc64el-cross
-          #        ;;
-          #   esac
       - name: Upload wheels
         uses: actions/upload-artifact@v7
         with:
@@ -145,7 +118,7 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
       - name: Build wheels
         uses: PyO3/maturin-action@e83996d129638aa358a18fbd1dfb82f0b0fb5d3b # v1.51.0
@@ -180,7 +153,7 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
       - name: Build wheels
         uses: PyO3/maturin-action@e83996d129638aa358a18fbd1dfb82f0b0fb5d3b # v1.51.0
diff --git a/.github/workflows/run-dev-tests.yml b/.github/workflows/run-dev-tests.yml
@@ -30,22 +30,8 @@ concurrency:
 
 jobs:
   seed-build-script:
-    runs-on: ubuntu-latest
     name: Pre-seed static binaries' versions
-    steps:
-      - env:
-          GITHUB_TOKEN: ${{ github.token }}
-        run: >-
-          gh release download
-          -R cpp-linter/clang-tools-static-binaries
-          --pattern versions.json
-          --output versions.json
-      - name: Upload versions.json
-        uses: actions/upload-artifact@v7
-        with:
-          name: static-binary-versions
-          path: versions.json
-          if-no-files-found: error
+    uses: ./.github/workflows/pre-seed-versions.yml
 
   test:
     needs: [seed-build-script]
@@ -120,7 +106,7 @@ jobs:
       - name: Restore build script seed
         uses: actions/download-artifact@v8
         with:
-          name: static-binary-versions
+          name: ${{ needs.seed-build-script.outputs.artifact-name }}
           path: clang-tools-manager
 
       - name: Run test suite
diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
@@ -1,7 +1,8 @@
 name: 'Close stale issues'
 on:
   schedule:
-    - cron: '30 1 * * *'
+    # Run at 1:30 AM every Monday, Wednesday, and Friday
+    - cron: '30 1 * * 1,3,5'
 
 permissions: {}
 
diff --git a/clang-tools-manager/src/downloader/hashing.rs b/clang-tools-manager/src/downloader/hashing.rs
@@ -16,9 +16,20 @@ use std::{fs, io::Read, num::NonZero, path::Path};
 pub enum HashAlgorithm {
     /// SHA-256 hash algorithm with the expected checksum value.
     Sha256(String),
+
     /// BLAKE2b-256 hash algorithm with the expected checksum value.
     Blake2b256(String),
+
     /// SHA-512 hash algorithm with the expected checksum value.
+    #[cfg(any(
+        // Windows support is only for x86_64 architecture (for now)
+        all(target_os = "windows", target_arch = "x86_64"),
+        // Linux and macOS support only x86_64 and aarch64 architectures
+        all(
+            any(target_os = "linux", target_os = "macos"),
+            any(target_arch = "x86_64", target_arch = "aarch64")
+        ),
+    ))]
     Sha512(String),
 }
 
@@ -74,6 +85,15 @@ impl HashAlgorithm {
                 let hasher = Blake2b::<U32>::new();
                 Self::hash_file(hasher, file_path, expected)
             }
+            #[cfg(any(
+                // Windows support is only for x86_64 architecture (for now)
+                all(target_os = "windows", target_arch = "x86_64"),
+                // Linux and macOS support only x86_64 and aarch64 architectures
+                all(
+                    any(target_os = "linux", target_os = "macos"),
+                    any(target_arch = "x86_64", target_arch = "aarch64")
+                ),
+            ))]
             HashAlgorithm::Sha512(expected) => {
                 use sha2::{Digest, Sha512};
 
diff --git a/clang-tools-manager/src/downloader/static_dist.rs b/clang-tools-manager/src/downloader/static_dist.rs
diff --git a/nurfile b/nurfile
