refactor: migrate to git-bot-feedback lib (#304)

resolves #97

This has 2 main benefits:

1. Improved PR review support. The [git-bot-feedback] lib automatically
hides outdated suggestions and reviews.
2. Any further CI platform support can get implemented in the
[git-bot-feedback] lib. This way, cpp-linter gets the newly supported CI
platforms for "free."

During review, I found a way to remove dependence on OpenSSL in both
libgit2 and reqwest libraries. We are now using rustls as our TLS
backend for HTTP requests.

[git-bot-feedback]: https://github.com/2bndy5/git-bot-feedback

Author: 2bndy5

.config/nextest.toml

@@ -20,16 +20,17 @@ status-level = "skip"
 # Run this profile before other tests to warmup the cache of clang tools binaries.
 default-filter = 'test(#*eval_version)'
 
+# only show the job(s) being run in this profile
+status-level = "pass"
+
 [profile.ci]
 # A profile to run only tests that use clang-tidy and/or clang-format
 # NOTE: This profile is intended to keep CI runtime low. Locally, use default or all profiles
 
-# This is all tests in tests/ folder + unit test for --extra-args.
-default-filter = "kind(test) + test(#*use_extra_args) + test(#*eval_version)"
+default-filter = "(kind(test) + test(use_extra_args)) - package(clang-installer)"
 
-# show log output from each test
-success-output = "final"
-failure-output = "immediate-final"
+# show log output from each failing test
+failure-output = "final"
 
 [profile.all]
 # A profile to run all tests (including tests that run longer than 10 seconds)

.github/install-clang-action/README.md

@@ -42,63 +42,48 @@ jobs:
         include:
           - target: aarch64-unknown-linux-gnu
             os: ubuntu-latest
-            vendored: true
             cross: true
           - target: aarch64-unknown-linux-musl
             os: ubuntu-latest
-            vendored: true
             cross: true
           - target: x86_64-unknown-linux-gnu
             os: ubuntu-latest
-            vendored: false
             cross: false
           - target: x86_64-unknown-linux-musl
             os: ubuntu-latest
-            vendored: true
             cross: true
           - target: arm-unknown-linux-gnueabi
             os: ubuntu-latest
-            vendored: true
             cross: true
           - target: arm-unknown-linux-gnueabihf
             os: ubuntu-latest
-            vendored: true
             cross: true
           - target: armv7-unknown-linux-gnueabihf
             os: ubuntu-latest
-            vendored: true
             cross: true
           - target: powerpc-unknown-linux-gnu
             os: ubuntu-latest
-            vendored: true
             cross: true
-          # - target: powerpc64-unknown-linux-gnu
-          #   os: ubuntu-latest
-          #   vendored: true
-          #   cross: true
+          - target: powerpc64-unknown-linux-gnu
+            os: ubuntu-latest
+            cross: true
           - target: powerpc64le-unknown-linux-gnu
             os: ubuntu-latest
-            vendored: true
             cross: true
           - target: s390x-unknown-linux-gnu
             os: ubuntu-latest
-            vendored: true
             cross: true
           - target: aarch64-apple-darwin
             os: macos-latest
-            vendored: true
             cross: false
           - target: x86_64-apple-darwin
             os: macos-latest
-            vendored: true
             cross: false
           - target: x86_64-pc-windows-msvc
             os: windows-latest
-            vendored: false
             cross: false
           - target: aarch64-pc-windows-msvc
             os: windows-latest
-            vendored: false
             cross: false
     runs-on: ${{ matrix.os }}
     permissions:
@@ -136,7 +121,7 @@ jobs:
           --bin clang-tools
           --release
           --target ${{ matrix.target }}
-          --features ${{ matrix.vendored && 'bin,openssl-vendored' || 'bin' }}
+          --features bin
 
       - name: Prepare artifacts (unix)
         if: runner.os != 'Windows'

.github/install-clang-action/action.yml

@@ -45,7 +45,7 @@ jobs:
         settings:
           - host: macos-latest
             target: x86_64-apple-darwin
-            build: yarn build --target x86_64-apple-darwin --features openssl-vendored
+            build: yarn build --target x86_64-apple-darwin
           - host: windows-latest
             build: yarn build --target x86_64-pc-windows-msvc
             target: x86_64-pc-windows-msvc
@@ -54,22 +54,22 @@ jobs:
             target: i686-pc-windows-msvc
           - host: ubuntu-latest
             target: x86_64-unknown-linux-gnu
-            build: yarn build --target x86_64-unknown-linux-gnu --use-cross --features openssl-vendored
+            build: yarn build --target x86_64-unknown-linux-gnu --use-cross
           - host: ubuntu-latest
             target: x86_64-unknown-linux-musl
-            build: yarn build --target x86_64-unknown-linux-musl -x --features openssl-vendored
+            build: yarn build --target x86_64-unknown-linux-musl -x
           - host: macos-latest
             target: aarch64-apple-darwin
-            build: yarn build --target aarch64-apple-darwin --features openssl-vendored
+            build: yarn build --target aarch64-apple-darwin
           - host: ubuntu-latest
             target: aarch64-unknown-linux-gnu
-            build: yarn build --target aarch64-unknown-linux-gnu --use-cross --features openssl-vendored
+            build: yarn build --target aarch64-unknown-linux-gnu --use-cross
           - host: ubuntu-latest
             target: armv7-unknown-linux-gnueabihf
-            build: yarn build --target armv7-unknown-linux-gnueabihf --use-cross --features openssl-vendored
+            build: yarn build --target armv7-unknown-linux-gnueabihf --use-cross
           - host: ubuntu-latest
             target: aarch64-unknown-linux-musl
-            build: yarn build --target aarch64-unknown-linux-musl -x --features openssl-vendored
+            build: yarn build --target aarch64-unknown-linux-musl -x
           - host: windows-latest
             target: aarch64-pc-windows-msvc
             build: yarn build --target aarch64-pc-windows-msvc
@@ -100,20 +100,20 @@ jobs:
             target/
           key: ${{ matrix.settings.target }}-cargo-${{ matrix.settings.host }}
       - uses: mlugg/setup-zig@d1434d08867e3ee9daa34448df10607b98908d29 # v2.2.1
-        if: ${{ contains(matrix.settings.build, ' -x ') }}
+        if: ${{ endsWith(matrix.settings.build, ' -x') }}
         with:
           version: 0.14.1
           use-cache: true # zizmor: ignore[cache-poisoning]
       - name: Install cargo-binstall
-        if: contains(matrix.settings.build, ' -x ') || contains(matrix.settings.build, '--use-cross ')
+        if: endsWith(matrix.settings.build, ' -x') || endsWith(matrix.settings.build, '--use-cross')
         uses: cargo-bins/cargo-binstall@aaa84a43aec4955a42c5ffc65d258961e39f276e # v1.19.1
         env:
           GITHUB_TOKEN: ${{ github.token }}
-      - name: Install ${{contains(matrix.settings.build, ' -x ') && 'cargo-zigbuild' || 'cargo-cross'}}
-        if: contains(matrix.settings.build, ' -x ') || contains(matrix.settings.build, '--use-cross ')
+      - name: Install ${{endsWith(matrix.settings.build, ' -x') && 'cargo-zigbuild' || 'cargo-cross'}}
+        if: endsWith(matrix.settings.build, ' -x') || endsWith(matrix.settings.build, '--use-cross')
         env:
           GITHUB_TOKEN: ${{ github.token }}
-          tool: ${{contains(matrix.settings.build, ' -x ') && 'cargo-zigbuild' || 'cross'}}
+          tool: ${{endsWith(matrix.settings.build, ' -x') && 'cargo-zigbuild' || 'cross'}}
         run: cargo binstall -y $tool
       - name: Setup toolchain
         run: ${{ matrix.settings.setup }}
@@ -139,8 +139,7 @@ jobs:
       - uses: actions/checkout@v6
         with:
           persist-credentials: false
-      - name: Build
-        id: build
+      - name: setup FreeBSD VM
         uses: cross-platform-actions/action@0c165ad7eb2d6a7e8552d6af5aad2bbedfc646b0 # v1.1.0
         env:
           DEBUG: napi:*
@@ -151,29 +150,30 @@ jobs:
           memory: 8G
           cpu_count: 3
           environment_variables: DEBUG RUSTUP_IO_THREADS
-          shell: bash
-          run: |
-            sudo pkg install -y -f curl node libnghttp2 npm cmake
-            sudo npm install -g yarn --ignore-scripts
-            curl https://sh.rustup.rs -sSf --output rustup.sh
-            sh rustup.sh -y --profile minimal --default-toolchain stable
-            source "$HOME/.cargo/env"
-            echo "~~~~ rustc --version ~~~~"
-            rustc --version
-            echo "~~~~ node -v ~~~~"
-            node -v
-            echo "~~~~ yarn --version ~~~~"
-            yarn --version
-            pwd
-            ls -lah
-            whoami
-            env
-            freebsd-version
-            yarn install
-            yarn build
-            rm -rf node_modules
-            rm -rf target
-            rm -rf .yarn/cache
+      - name: Build
+        shell: cpa.sh {0}
+        run: |-
+          sudo pkg install -y -f curl node libnghttp2 npm cmake
+          sudo npm install -g yarn --ignore-scripts
+          curl https://sh.rustup.rs -sSf --output rustup.sh
+          sh rustup.sh -y --profile minimal --default-toolchain stable
+          . "$HOME/.cargo/env"
+          echo "~~~~ rustc --version ~~~~"
+          rustc --version
+          echo "~~~~ node -v ~~~~"
+          node -v
+          echo "~~~~ yarn --version ~~~~"
+          yarn --version
+          pwd
+          ls -lah
+          whoami
+          env
+          freebsd-version
+          yarn install
+          yarn build
+          rm -rf node_modules
+          rm -rf target
+          rm -rf .yarn/cache
       - name: Upload artifact
         uses: actions/upload-artifact@v7
         with:

.github/workflows/binary-builds.yml

@@ -5,11 +5,7 @@
 #
 # NOTE: There are some customizations added to the generated output.
 # - workflow name is more descriptive
-# - use openssl-vendored cargo feature on
-#   * most cross-compiled Linux wheels
-#   * all MacOS builds
-# - musl linux builds (& x390 Linux target) are excluded due to complexity of
-#   installing openSSL lib in cross-compiler's docker/env.
+# - use zig compiler on most cross-compiled Linux wheels
 name: Python builds
 
 on:
@@ -60,8 +56,8 @@ jobs:
             target: aarch64
           - runner: ubuntu-latest
             target: armv7
-          # - runner: ubuntu-latest
-          #   target: s390x
+          - runner: ubuntu-latest
+            target: s390x
           - runner: ubuntu-latest
             target: ppc64le
     steps:
@@ -72,34 +68,33 @@ jobs:
         with:
           python-version: '3.x'
 
-      - name: Calculate openssl-vendored
-        shell: bash
-        id: is-openssl-vendored
-        run: |
-          if [[ "${{ startsWith(matrix.platform.target, 'x86') }}" == "true" ]]; then
-            echo "enabled=" >> $GITHUB_OUTPUT
-          else
-            echo "enabled=--features openssl-vendored" >> $GITHUB_OUTPUT
-          fi
-
       - name: Build wheels
         uses: PyO3/maturin-action@e83996d129638aa358a18fbd1dfb82f0b0fb5d3b # v1.51.0
         with:
           target: ${{ matrix.platform.target }}
-          args: --release --out dist --find-interpreter ${{ steps.is-openssl-vendored.outputs.enabled }}
-          # sccache: ${{ !startsWith(github.ref, 'refs/tags/') }} # zizmor: ignore[cache-poisoning]
+          # Use the zig toolchain for all targets except ppc64le.
+          # Note, this is meant to avoid build errors in aws-lc-sys crate, which compiles C code.
+          args: >-
+            --release --out dist --find-interpreter
+            ${{ matrix.platform.target != 'ppc64le' && '--zig' || ''}}
+          # avoid cache-poisoning potential for actually distributed builds
+          sccache: ${{ startsWith(github.ref, 'refs/tags') && 'false' || 'true' }}
           manylinux: auto
+          # here we either install the ppc64le compiler/toolchain or install zig on all others
           before-script-linux: |
             case "${{ matrix.platform.target }}" in
-              "aarch64" | "armv7" | "s390x" | "ppc64le")
-                # NOTE: pypa/manylinux docker images are Debian based
-                sudo apt-get update
-                sudo apt-get install -y pkg-config libssl-dev
+              ppc64le)
+                apt-get update
+                apt-get install -y \
+                  pkg-config \
+                  gcc-powerpc64le-linux-gnu \
+                  g++-powerpc64le-linux-gnu \
+                  binutils-powerpc64le-linux-gnu \
+                  libc6-dev-ppc64el-cross
                 ;;
-              "x86" | "x86_64")
-                # NOTE: rust-cross/manylinux docker images are CentOS based
-                yum update -y
-                yum install -y openssl openssl-devel
+              *)
+                # spell-checker: disable-next-line
+                pip install ziglang
                 ;;
             esac
       - name: Upload wheels
@@ -158,7 +153,7 @@ jobs:
         uses: PyO3/maturin-action@e83996d129638aa358a18fbd1dfb82f0b0fb5d3b # v1.51.0
         with:
           target: ${{ matrix.platform.target }}
-          args: --release --out dist --find-interpreter --features openssl-vendored
+          args: --release --out dist --find-interpreter
           sccache: ${{ !startsWith(github.ref, 'refs/tags/') }} # zizmor: ignore[cache-poisoning]
       - name: Upload wheels
         uses: actions/upload-artifact@v7