Skip to content

fix: rename temp downloaded file to given cache path#332

Merged
2bndy5 merged 2 commits into
mainfrom
no-atomic-rename
Jun 6, 2026
Merged

fix: rename temp downloaded file to given cache path#332
2bndy5 merged 2 commits into
mainfrom
no-atomic-rename

explicitly close the tmp file before renaming

94a806c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 6, 2026 in 1s

90.91% (-0.04%) compared to 8e2fcad

View this Pull Request on Codecov

90.91% (-0.04%) compared to 8e2fcad

Details

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.91%. Comparing base (8e2fcad) to head (94a806c).

Files with missing lines Patch % Lines
clang-installer/src/downloader/mod.rs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   90.94%   90.91%   -0.04%     
==========================================
  Files          22       22              
  Lines        3368     3378      +10     
==========================================
+ Hits         3063     3071       +8     
- Misses        305      307       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.