Skip to content

feat: merge review suggestions from both clang tools - #358

Merged
2bndy5 merged 2 commits into
mainfrom
join-tools-reviews
Jun 18, 2026
Merged

feat: merge review suggestions from both clang tools#358
2bndy5 merged 2 commits into
mainfrom
join-tools-reviews

impl 3-way diff and add tests

aa76d57
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 18, 2026 in 1s

92.35% (-0.46%) compared to badba09

View this Pull Request on Codecov

92.35% (-0.46%) compared to badba09

Details

Codecov Report

❌ Patch coverage is 90.96573% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.35%. Comparing base (badba09) to head (aa76d57).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cpp-linter/src/clang_tools/clang_format.rs 84.00% 20 Missing ⚠️
cpp-linter/src/common_fs.rs 89.65% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   92.81%   92.35%   -0.46%     
==========================================
  Files          23       23              
  Lines        3450     3597     +147     
==========================================
+ Hits         3202     3322     +120     
- Misses        248      275      +27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.