Fix Fail-Slow / exit-code masking (#59)

* propagate submodule and clone failures through finalize exit codes

* fix the coderabbitai review comments

* run the code-cleanup tool

* fix the coderabbitai review comments

* run the code-review tool

* fix the first reviewer comment

Author: whisper67265

.github/workflows/assets/README.md

@@ -13,9 +13,11 @@ PR is merged into a `local-{lang_code}` branch.
 **Condition:** PR must be merged (`github.event.pull_request.merged == true`) and the head
 branch must start with `translation-` (Weblate-created branches).
 
-**Bot identity:** The “Create and push tag” step sets
-`user.email` to `Boost-Translation-CI-Bot@cppalliance.local`, matching the
-orchestration bot pattern in [`env.sh`](env.sh) for the mirror’s GitHub org.
+**Bot identity:** The “Create and push tag” step sources [`env.sh`](env.sh) and
+[`lib.sh`](lib.sh), then calls **`set_git_bot_config "$GITHUB_WORKSPACE"`** so
+`user.name` / `user.email` match the orchestration bot pattern:
+**`BOT_EMAIL="Boost-Translation-CI-Bot@$ORG.local"`** (with **`ORG`** derived from
+**`GITHUB_REPOSITORY`** in the mirror repo).
 
 **How it works:**
 

.github/workflows/assets/add_submodules.sh

@@ -30,7 +30,6 @@ create_new_repo_and_push() {
   git -C "$sub_clone" remote remove origin 2>/dev/null || true
   git -C "$sub_clone" remote add origin "$repo_url" || return 2
   git -C "$sub_clone" push -u origin "$MASTER_BRANCH" || return 2
-  git -C "$sub_clone" push origin "$MASTER_BRANCH" || return 2
   for lang_code in "${lang_codes_arr[@]}"; do
     local local_br="${LOCAL_BRANCH_PREFIX}${lang_code}"
     git -C "$sub_clone" checkout -B "$local_br" "$MASTER_BRANCH" || return 2

.github/workflows/assets/create-tag.yml

@@ -61,7 +61,10 @@ jobs:
             echo "Tag $TAGNAME already exists, skipping."
             exit 0
           fi
-          git config user.name "Boost-Translation-CI-Bot"
-          git config user.email "Boost-Translation-CI-Bot@cppalliance.local"
+          # shellcheck source=assets/env.sh
+          source "$GITHUB_WORKSPACE/.github/workflows/assets/env.sh"
+          # shellcheck source=assets/lib.sh
+          source "$GITHUB_WORKSPACE/.github/workflows/assets/lib.sh"
+          set_git_bot_config "$GITHUB_WORKSPACE"
           git tag "$TAGNAME"
           git push origin "$TAGNAME"

.github/workflows/assets/lib.sh

@@ -72,7 +72,7 @@ has_open_translation_pr() {
 # Clone repo at branch/tag into $3. Pass "keep" as $4 to preserve .git.
 clone_repo() {
   mkdir -p "$3"
-  git clone --branch "$2" "$1" "$3"
+  git clone --branch "$2" "$1" "$3" || return 2
   [[ "${4:-}" == "keep" ]] || rm -rf "$3/.git"
 }
 
@@ -236,9 +236,10 @@ commit_and_push_translations_branch() {
 # Update one branch of the translations super-repo (checkout → update pointers → push).
 sync_translations_branch() {
   local dir="$1" branch="$2" libs_ref="$3" force="${4:-false}"
+  local sub
   git -C "$dir" checkout -B "$branch" "origin/$branch"
   for sub in "${UPDATES[@]}"; do
-    update_translations_submodule "$dir" "$MODULE_ORG" "$sub" "$branch"
+    update_translations_submodule "$dir" "$MODULE_ORG" "$sub" "$branch" || return 2
   done
   commit_and_push_translations_branch "$dir" "$branch" "$libs_ref" "$force"
 }
@@ -350,16 +351,10 @@ record_submodule_fatal() {
 }
 
 # Summary bucket globals; filled by sync_one_submodule before print_submodule_processing_summary.
-# add-submodules uses init_add_submodule_summary_buckets for REPO_EXISTS_SKIP.
 init_submodule_summary_buckets() {
   META_MISSING=()
   NO_DOC_PATHS=()
   ORG_REPO_MISSING=()
-}
-
-init_add_submodule_summary_buckets() {
-  META_MISSING=()
-  NO_DOC_PATHS=()
   REPO_EXISTS_SKIP=()
 }
 

.github/workflows/assets/submodule_ops.sh

@@ -10,8 +10,9 @@
 # Per-submodule batch return convention (see docs/ARCHITECTURE.md §6):
 #   0 = success, 1 = non-fatal skip, 2 = fatal error.
 # process_submodule_list collapses 2 → submodule_fatal; combine_batch_and_finalize_rc
-# maps submodule_fatal to job exit 1 (finalize_rc wins when non-zero).
-# shellcheck disable=SC2034,SC2154
+# maps submodule_fatal to job exit 1 (finalize_rc wins when non-zero; optional weblate_rc
+# overrides both when non-zero).
+# shellcheck disable=SC2034,SC2154,SC2153
 
 # Create temp workspace dirs. Pass "with_org_work" to also set ORG_WORK.
 init_translation_work_dirs() {
@@ -46,11 +47,11 @@ libs_submodule_names_from_gitmodules_file() {
     | sed 's|^libs/||'
 }
 
-# Fetch boostorg/boost .gitmodules at ref; print raw content. Return 1 on failure.
+# Fetch ${BOOST_ORG}/boost .gitmodules at ref; print raw content. Return 1 on failure.
 fetch_boost_gitmodules_at_ref() {
   local ref="$1"
   gh api \
-    "repos/boostorg/boost/contents/.gitmodules?ref=$ref" \
+    "repos/${BOOST_ORG}/boost/contents/.gitmodules?ref=$ref" \
     -H "Accept: application/vnd.github.v3.raw" 2>/dev/null
 }
 
@@ -64,7 +65,7 @@ resolve_add_submodules_names() {
     echo "Using ${#submodule_names[@]} submodules from input." >&2
     return 0
   fi
-  echo "Fetching .gitmodules from boostorg/boost at ${libs_ref_for_fetch}..." >&2
+  echo "Fetching .gitmodules from ${BOOST_ORG}/boost at ${libs_ref_for_fetch}..." >&2
   local gitmodules_content
   gitmodules_content=$(fetch_boost_gitmodules_at_ref "$libs_ref_for_fetch") || {
     phase_err "Failed to fetch .gitmodules"
@@ -115,12 +116,14 @@ process_submodule_list() {
   return 0
 }
 
-# Combine submodule_fatal count with finalize_rc; return combined exit code.
+# Combine submodule_fatal count with finalize_rc and optional weblate_rc; return combined exit code.
 combine_batch_and_finalize_rc() {
   local finalize_rc="${1:-0}"
+  local weblate_rc="${2:-0}"
   local exit_rc=0
   [[ "${submodule_fatal:-0}" -gt 0 ]] && exit_rc=1
   [[ "$finalize_rc" -ne 0 ]] && exit_rc=$finalize_rc
+  [[ "$weblate_rc" -ne 0 ]] && exit_rc=$weblate_rc
   return "$exit_rc"
 }
 
@@ -129,7 +132,7 @@ add_submodules_main() {
   local rc finalize_rc exit_rc
 
   init_translation_state
-  init_add_submodule_summary_buckets
+  init_submodule_summary_buckets
 
   begin_phase "$PHASE_SETUP" "Validate inputs and prepare workspace"
   validate_secrets

.github/workflows/assets/translation.sh

@@ -219,10 +219,6 @@ trigger_weblate() {
   add_or_update_json=$(jq -n --arg lc "$lang_code" --argjson s "$subs_json" \
     '{($lc): $s}')
 
-  [[ "$add_or_update_json" == "{}" ]] && {
-    echo "Weblate skipped: no translations to update." >&2; return
-  }
-
   local payload
   payload=$(jq -n \
     --arg org "$MODULE_ORG" --arg ver "$libs_ref" \

.github/workflows/start-translation.yml

@@ -59,7 +59,7 @@ jobs:
           source "$GITHUB_WORKSPACE/.github/workflows/assets/lib.sh"
           begin_phase "$PHASE_SETUP" "Validate language matrix"
           parse_and_validate_lang_codes
-          langs_json=$(printf '%s\n' "${lang_codes_arr[@]}" | jq -R . | jq -s -c .)
+          langs_json=$(submodule_names_to_json "${lang_codes_arr[@]}")
           echo "json=$langs_json" >> "$GITHUB_OUTPUT"
           echo "Lang codes: ${lang_codes_arr[*]}" >&2
           end_phase
@@ -282,10 +282,6 @@ jobs:
             echo "Skipping Weblate add-or-update: finalize_translations_local failed (rc=$rc)." >&2
           fi
 
-          exit_rc=0
-          [[ $submodule_fatal -gt 0 ]] && exit_rc=1
-          [[ $rc -ne 0 ]] && exit_rc=$rc
-          [[ $weblate_rc -ne 0 ]] && exit_rc=$weblate_rc
-          [[ $exit_rc -ne 0 ]] && exit $exit_rc
+          combine_batch_and_finalize_rc "$rc" "$weblate_rc" || exit $?
 
           echo "Done." >&2

.github/workflows/sync-translation.yml

@@ -74,7 +74,7 @@ jobs:
           done
           validate_lang_codes "${lang_codes_arr[@]}"
 
-          langs_json=$(printf '%s\n' "${lang_codes_arr[@]}" | jq -R . | jq -s -c .)
+          langs_json=$(submodule_names_to_json "${lang_codes_arr[@]}")
           echo "json=$langs_json" >> "$GITHUB_OUTPUT"
           end_phase
 
@@ -111,8 +111,7 @@ jobs:
           # shellcheck source=assets/lib.sh
           source "$GITHUB_WORKSPACE/.github/workflows/assets/lib.sh"
 
-          git config user.name "$BOT_NAME"
-          git config user.email "$BOT_EMAIL"
+          set_git_bot_config "$GITHUB_WORKSPACE"
 
           branch="${LOCAL_BRANCH_PREFIX}${SYNC_LANG}"
           begin_phase "$PHASE_SYNC_POINTERS" "Sync pointers on $branch"

CHANGELOG.md

@@ -25,12 +25,28 @@ are a separate namespace — see [README](README.md#releases) and
 
 ### Changed
 
+- Extracted shared dispatch helpers into
+  [`scripts/trigger-dispatch-common.sh`](scripts/trigger-dispatch-common.sh)
+  (`DEFAULT_REPO`, `DEFAULT_VERSION`, JSON build, `POST …/dispatches`); both
+  `trigger-*.sh` wrappers source it.
+- Mirror **`create-tag.yml`** bot identity now uses **`set_git_bot_config`** from
+  **`env.sh`** / **`lib.sh`** instead of a hardcoded org email.
 - Renamed and expanded operator quick reference to
   [GETTING-STARTED.md](docs/GETTING-STARTED.md): end-to-end walkthrough with
   per-step verification and create-tag coverage.
 - [endpoint-contract.md](docs/endpoint-contract.md) Outbound Weblate section:
   request schema is now the source of truth for payload fields.
 
+### Fixed
+
+- Clone and finalize steps now fail fast: **`clone_repo`**, **`sync_translations_branch`**,
+  and **`finalize_translations_*`** propagate non-zero status instead of continuing with
+  incomplete state.
+- **`combine_batch_and_finalize_rc`** collapses all three exit sources—batch
+  **`submodule_fatal`**, **`finalize_rc`**, and optional **`weblate_rc`**—with documented
+  last-wins priority; **`start-translation.yml`** **`start-local`** delegates to it instead
+  of inline collapse logic.
+
 ## [1.0.0] - 2026-07-07
 
 Initial semver baseline for the orchestration repo. Summarizes the operator and

README.md

@@ -182,6 +182,8 @@ From a clone of this repo:
 - **`scripts/trigger-add-submodules.sh`** — fires **`add-submodules`**.
 - **`scripts/trigger-start-translation.sh`** — fires **`start-translation`** (optional
   **`--version`**, **`--lang-codes`**, **`--extensions`**).
+- **`scripts/trigger-dispatch-common.sh`** — shared by both triggers: **`DEFAULT_REPO`**,
+  **`DEFAULT_VERSION`**, JSON payload build, and **`POST …/dispatches`**.
 
 These wrappers use only **`exit 0`** (success, including **`--help`**) and **`exit 1`**
 (all errors); they do not implement the asset-script 0/1/2 batch return convention
@@ -207,7 +209,7 @@ documented below.
 | Variable         | Used by                               | Description                                                                                                                                                                                                                       |
 | ---------------- | ------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | `LANG_CODES`     | `add-submodules`, `start-translation` | Default language codes when **`client_payload.lang_codes`** is omitted (comma- or bracket-list, e.g. `zh_Hans,ja`). Must be set here or passed in the dispatch payload.                                                           |
-| `SUBMODULES_ORG` | `add-submodules`, `start-translation` | Optional. GitHub org for **`boostorg`** mirror repos (e.g. `CppDigest`). If unset, the org is the same as this repository’s owner. **`sync-translation`** relies on **`.gitmodules`** URLs already pointing at the correct hosts. |
+| `SUBMODULES_ORG` | `add-submodules`, `start-translation` | Optional. GitHub org for per-library mirror repos under **`MODULE_ORG`** (e.g. `CppDigest`). If unset, **`MODULE_ORG`** defaults to this repository’s owner. Upstream Boost libraries are cloned from **`boostorg`**. **`sync-translation`** relies on **`.gitmodules`** URLs already pointing at the correct hosts. |
 
 ## Development