Skip to content

Commit 34a9c4d

Browse files
committed
cookie_jar: improve test coverage
1 parent 0b74e07 commit 34a9c4d

3 files changed

Lines changed: 425 additions & 266 deletions

File tree

.drone.star

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,14 @@ def main(ctx):
2323
'gcc >=13.0',
2424
'clang >=17.0',
2525
# 'msvc >=14.1',
26-
'arm64-gcc latest',
2726
'arm64-clang latest'
2827
# 'x86-msvc latest'
2928
],
3029
'>=20',
30+
cmake=False,
3131
docs=False,
3232
coverage=False,
33+
asan=False,
3334
cache_dir='cache')
3435
# Note: liburing-dev is not added to generate()'s package list.
3536
# generate() emits jobs on Ubuntu focal (which has no liburing-dev
@@ -60,33 +61,33 @@ def main(ctx):
6061
# globalenv=globalenv),
6162
# ]
6263

63-
jobs += [
64-
freebsd_cxx("clang-22", "clang++-22",
65-
buildscript="drone", buildtype="boost",
66-
freebsd_version="15.0",
67-
environment={
68-
'B2_TOOLSET': 'clang-22',
69-
'B2_CXXSTD': '20',
70-
},
71-
globalenv=globalenv),
72-
]
64+
# jobs += [
65+
# freebsd_cxx("clang-22", "clang++-22",
66+
# buildscript="drone", buildtype="boost",
67+
# freebsd_version="15.0",
68+
# environment={
69+
# 'B2_TOOLSET': 'clang-22',
70+
# 'B2_CXXSTD': '20',
71+
# },
72+
# globalenv=globalenv),
73+
# ]
7374

7475
# Jobs not covered by generate()
7576
jobs += [
76-
linux_cxx("Valgrind", "clang++-17", packages="clang-17 libc6-dbg libstdc++-12-dev liburing-dev",
77-
llvm_os="jammy", llvm_ver="17",
78-
buildscript="drone", buildtype="valgrind",
79-
image="cppalliance/droneubuntu2204:1",
80-
environment={
81-
'COMMENT': 'valgrind',
82-
'B2_TOOLSET': 'clang-17',
83-
'B2_CXXSTD': '20',
84-
'B2_DEFINES': 'BOOST_NO_STRESS_TEST=1',
85-
'B2_VARIANT': 'debug',
86-
'B2_TESTFLAGS': 'testing.launcher=valgrind',
87-
'VALGRIND_OPTS': '--error-exitcode=1',
88-
},
89-
globalenv=globalenv),
77+
# linux_cxx("Valgrind", "clang++-17", packages="clang-17 libc6-dbg libstdc++-12-dev liburing-dev",
78+
# llvm_os="jammy", llvm_ver="17",
79+
# buildscript="drone", buildtype="valgrind",
80+
# image="cppalliance/droneubuntu2204:1",
81+
# environment={
82+
# 'COMMENT': 'valgrind',
83+
# 'B2_TOOLSET': 'clang-17',
84+
# 'B2_CXXSTD': '20',
85+
# 'B2_DEFINES': 'BOOST_NO_STRESS_TEST=1',
86+
# 'B2_VARIANT': 'debug',
87+
# 'B2_TESTFLAGS': 'testing.launcher=valgrind',
88+
# 'VALGRIND_OPTS': '--error-exitcode=1',
89+
# },
90+
# globalenv=globalenv),
9091

9192
# Note: no liburing-dev on the Drone cmake jobs even though the
9293
# noble image has 2.5+. Docker's default seccomp profile blocks

src/cookie_jar.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ domain_match(
4040
if(!tailmatch)
4141
return host == domain;
4242

43-
if(domain.starts_with('.'))
44-
domain.remove_prefix(1);
45-
4643
if(host.ends_with(domain))
4744
{
4845
if(host.size() == domain.size())

0 commit comments

Comments
 (0)