fix: split parse/stats errors in export and stats routes; tighten tests

Author: clean6378-max-it

api/export_api.py

@@ -284,15 +284,38 @@ def export_session(project_name, session_id):
         )
 
     fmt = request.args.get("format", "md")
-    session = parse_session(filepath)
+    try:
+        session = parse_session(filepath)
+    except Exception:
+        current_app.logger.exception(
+            "Failed to parse session %s for export", session_id
+        )
+        return error_response(
+            ErrorCode.PARSE_ERROR,
+            "Failed to parse session",
+            400,
+        )
+
     rules = current_app.config.get("EXCLUSION_RULES") or []
     if is_session_excluded(rules, session, project_name):
         return error_response(
             ErrorCode.SESSION_NOT_FOUND,
             "Session not found",
             404,
         )
-    stats = compute_stats(session)
+
+    try:
+        stats = compute_stats(session)
+    except Exception:
+        current_app.logger.exception(
+            "Failed to compute stats for export %s", session_id
+        )
+        return error_response(
+            ErrorCode.INTERNAL_ERROR,
+            "Failed to compute session stats",
+            500,
+        )
+
     title_slug = slugify(session["title"], default="session")
 
     if fmt == "json":

api/sessions.py

@@ -64,6 +64,15 @@ def get_session_stats(project_name, session_id):
 
     try:
         session = parse_session(filepath)
+    except Exception:
+        current_app.logger.exception("Failed to parse session %s", session_id)
+        return error_response(
+            ErrorCode.PARSE_ERROR,
+            "Failed to parse session",
+            400,
+        )
+
+    try:
         stats = compute_stats(session)
         return jsonify(stats)
     except Exception:

tests/test_api_routes.py

@@ -56,7 +56,9 @@ def _boom(*_args, **_kwargs):
 def test_search_limit_capped_at_max(client):
     resp = client.get("/api/search?q=Hello&limit=9999")
     assert resp.status_code == 200
-    assert len(resp.get_json()) <= 500
+    results = resp.get_json()
+    assert isinstance(results, list)
+    assert len(results) <= 500
 
 
 def test_project_sessions_invalid_path_returns_400_empty_list(client):

tests/test_cli_e2e.py

@@ -40,18 +40,17 @@ def _seed_base_dir(tmp_path: Path) -> Path:
     project_dir = tmp_path / "test-project"
     project_dir.mkdir(parents=True)
     dest = project_dir / "session_abc123.jsonl"
-    dest.write_text(
-        (FIXTURES / "session_minimal.jsonl").read_text(encoding="utf-8"),
-        encoding="utf-8",
-    )
+    content = (FIXTURES / "session_minimal.jsonl").read_text(encoding="utf-8")
+    content = content.replace("demo-project", "test-project")
+    dest.write_text(content, encoding="utf-8")
     return tmp_path
 
 
 def test_cli_list_exits_zero(tmp_path):
     base = _seed_base_dir(tmp_path)
     proc = _run_cli(["list", "--base-dir", str(base)])
     assert proc.returncode == 0
-    assert "test-project" in proc.stdout or "Project" in proc.stdout
+    assert "test-project" in proc.stdout.lower()
 
 
 def test_cli_list_unknown_project_exits_zero_with_message(tmp_path):
@@ -70,6 +69,8 @@ def test_cli_stats_exits_zero(tmp_path):
 def test_cli_invalid_since_exits_nonzero():
     proc = _run_cli(["--since", "yesterday"])
     assert proc.returncode != 0
+    assert "--since" in proc.stderr
+    assert "invalid choice" in proc.stderr.lower()
 
 
 def test_cli_export_creates_output(tmp_path):

tests/test_error_propagation.py

@@ -154,9 +154,10 @@ def _boom(*args, **kwargs):
         monkeypatch.setattr("api.sessions.parse_session", _boom)
 
         resp = client.get("/api/sessions/proj/abc/stats")
-        assert resp.status_code == 500
+        assert resp.status_code == 400
         body = resp.get_json()
-        assert body.get("error") == "Failed to compute session stats"
+        assert body.get("error") == "Failed to parse session"
+        assert body.get("code") == "PARSE_ERROR"
         # The exception value contains a fake-secret path — must not leak.
         assert "/private/path" not in json.dumps(body)
         _assert_no_class_name_leak(json.dumps(body))

tests/test_search.py

@@ -7,11 +7,28 @@
 
 from tests.conftest import assert_error_response
 
+_SEARCH_HIT_KEYS = frozenset({
+    "project",
+    "session_id",
+    "title",
+    "role",
+    "timestamp",
+    "snippet",
+})
+
+
+def _assert_search_hits(results: list, *, max_items: int) -> None:
+    assert isinstance(results, list)
+    assert len(results) <= max_items
+    for item in results:
+        assert isinstance(item, dict)
+        assert _SEARCH_HIT_KEYS.issubset(item.keys())
+
 
 def test_limit_integer_string(client_single):
     resp = client_single.get("/api/search?q=Hello&limit=10")
     assert resp.status_code == 200
-    assert isinstance(resp.get_json(), list)
+    _assert_search_hits(resp.get_json(), max_items=10)
 
 
 def test_limit_float_string(client_single):
@@ -29,6 +46,7 @@ def test_limit_non_numeric(client_single):
 def test_limit_default(client_single):
     resp = client_single.get("/api/search?q=Hello")
     assert resp.status_code == 200
+    _assert_search_hits(resp.get_json(), max_items=50)
 
 
 def test_limit_whitespace_defaults(client_single):