test: address timon0305 PR review feedback

Add client_empty and client_thinking fixtures, exercise thinking
blocks via session detail API, preserve ValueError cause in _parse_limit,
and remove .coverage from git tracking (already in .gitignore).

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: clean6378-max-it

.coverage

@@ -20,8 +20,8 @@ def _parse_limit(raw: str | None) -> int:
         return _DEFAULT_LIMIT
     try:
         n = int(raw.strip())
-    except ValueError:
-        raise ValueError("limit must be a positive integer") from None
+    except ValueError as exc:
+        raise ValueError("limit must be a positive integer") from exc
     if n < 1:
         raise ValueError("limit must be a positive integer")
     return min(n, _MAX_LIMIT)

api/search.py

@@ -33,3 +33,22 @@ def client_single(tmp_path):
     app = create_app(base_dir=str(tmp_path))
     app.config["TESTING"] = True
     return app.test_client()
+
+
+@pytest.fixture
+def client_empty(tmp_path):
+    """Flask test client with an empty projects directory."""
+    app = create_app(base_dir=str(tmp_path))
+    app.config["TESTING"] = True
+    return app.test_client()
+
+
+@pytest.fixture
+def client_thinking(tmp_path):
+    """Flask test client with a session containing thinking content blocks."""
+    project_dir = tmp_path / "test-project"
+    project_dir.mkdir(parents=True)
+    shutil.copy(FIXTURES / "session_with_thinking.jsonl", project_dir / "session_think001.jsonl")
+    app = create_app(base_dir=str(tmp_path))
+    app.config["TESTING"] = True
+    return app.test_client()

tests/conftest.py

@@ -4,13 +4,11 @@
 Covers /api/projects, /api/projects/<name>/sessions, /api/sessions/<name>/<id>,
 and /api/search (Week 3 Tuesday, 8pt).
 
-The `client` fixture (two seeded sessions) is provided by tests/conftest.py.
+Fixtures (`client`, `client_empty`, `client_thinking`) live in tests/conftest.py.
 """
 
 from __future__ import annotations
 
-from app import create_app
-
 
 def _assert_error_shape(resp):
     body = resp.get_json()
@@ -33,10 +31,8 @@ def test_projects_returns_list(client):
     assert "path" in project
 
 
-def test_projects_empty_base_dir(tmp_path):
-    app = create_app(base_dir=str(tmp_path))
-    app.config["TESTING"] = True
-    resp = app.test_client().get("/api/projects")
+def test_projects_empty_base_dir(client_empty):
+    resp = client_empty.get("/api/projects")
     assert resp.status_code == 200
     assert resp.get_json() == []
 
@@ -79,6 +75,16 @@ def test_session_detail_not_found(client):
     _assert_error_shape(resp)
 
 
+def test_session_detail_includes_thinking_blocks(client_thinking):
+    resp = client_thinking.get("/api/sessions/test-project/session_think001")
+    assert resp.status_code == 200
+    session = resp.get_json()
+    assert "messages" in session
+    assistant_msgs = [m for m in session["messages"] if m.get("role") == "assistant"]
+    assert len(assistant_msgs) >= 1
+    assert assistant_msgs[0].get("thinking") == "Considering options carefully."
+
+
 # --- /api/search ---