fix(export): derive failure_count from failures list (PR #73 review)

Author: clean6378-max-it

tests/test_cli_export_exit_codes.py

@@ -13,8 +13,9 @@
 sys.path.insert(0, str(REPO_ROOT))
 
 import scripts.export as export
+from models.error_codes import ErrorCode
 from tests.test_cli_e2e import _run_cli, _seed_base_dir
-from utils.export_engine import BulkExportResult
+from utils.export_engine import BulkExportResult, ExportFailure
 from utils.jsonl_parser import parse_session
 
 _SUMMARY_RE = re.compile(
@@ -133,8 +134,17 @@ def _track_exit(result: BulkExportResult) -> None:
 
 
 def test_since_last_early_return_exits_one_on_failure(tmp_path, monkeypatch, capsys):
-    """Since-last early-return with failure_count>0 must produce real exit code 1."""
-    fake_result = BulkExportResult(latest_day=None, failure_count=1)
+    """Since-last early-return with failures must produce real exit code 1."""
+    fake_result = BulkExportResult(
+        latest_day=None,
+        failures=[
+            ExportFailure(
+                session_id="session_fail",
+                message="Failed to parse session",
+                code=ErrorCode.PARSE_ERROR,
+            )
+        ],
+    )
 
     monkeypatch.setattr(export, "run_bulk_export", lambda **kwargs: fake_result)
     monkeypatch.setattr(export, "list_projects", lambda base: [{"name": "p", "path": "/p"}])

utils/export_engine.py

@@ -104,7 +104,6 @@ class BulkExportResult:
     manifest: list[dict[str, Any]] = field(default_factory=list)
     new_sessions_map: dict[str, float] = field(default_factory=dict)
     exported_session_count: int = 0
-    failure_count: int = 0
     failures: list[ExportFailure] = field(default_factory=list)
     skipped_count: int = 0
     skipped_mtime_unchanged_count: int = 0
@@ -113,6 +112,11 @@ class BulkExportResult:
     latest_day_scan_total: int = 0
     latest_day_match_count: int = 0
 
+    @property
+    def failure_count(self) -> int:
+        """Number of per-session failures (derived from :attr:`failures`)."""
+        return len(self.failures)
+
 
 class ExportSink(Protocol):
     """Receives exported session files and final manifest."""
@@ -305,7 +309,6 @@ def _record_failure(
         *,
         phase: Literal["parse", "export"] = "parse",
     ) -> None:
-        result.failure_count += 1
         code = failure_code_for_exception(exc, phase=phase)
         result.failures.append(
             ExportFailure(