Add disk-backed session summary cache and display-name cache

Author: clean6378-max-it

api/projects.py

@@ -5,7 +5,6 @@
 from api._flask_types import FlaskReturn, json_response
 from api.error_codes import ErrorCode, error_response
 from models.project import ProjectSessionRowDict, SessionListItemDict
-from models.session import SessionDict
 from utils.exclusion_rules import is_session_excluded
 from utils.jsonl_parser import quick_session_info
 from utils.session_cache import get_cached_session
@@ -23,23 +22,6 @@
 projects_bp = Blueprint("projects", __name__)
 
 
-def _session_row_ok(s: SessionListItemDict, parsed: SessionDict) -> ProjectSessionRowDict:
-    meta = parsed["metadata"]
-    models = meta.get("models_used", [])
-    return {
-        "id": s["id"],
-        "path": s["path"],
-        "size_bytes": s["size_bytes"],
-        "modified": s["modified"],
-        "title": parsed["title"],
-        "models": sorted(models) if isinstance(models, set) else list(models),
-        "tokens": meta["total_input_tokens"] + meta["total_output_tokens"],
-        "tool_calls": meta["total_tool_calls"],
-        "first_timestamp": meta["first_timestamp"],
-        "last_timestamp": meta["last_timestamp"],
-    }
-
-
 def _session_row_error(s: SessionListItemDict) -> ProjectSessionRowDict:
     return {
         "id": s["id"],
@@ -85,6 +67,10 @@ def get_projects() -> FlaskReturn:
                 if ts and (latest_ts is None or ts > latest_ts):
                     latest_ts = ts
             except Exception:
+                current_app.logger.exception(
+                    "Failed to peek session summary for project %s",
+                    project["name"],
+                )
                 titled_count += 1
         project["session_count"] = titled_count
         if latest_ts:
@@ -119,7 +105,7 @@ def get_project_sessions(project_name: str) -> FlaskReturn:
             put_summary(s["path"], s["modified"], rules_fp, row)
             if row["is_untitled"] or excluded:
                 continue
-            result.append(_session_row_ok(s, parsed))
+            result.append(session_row_from_summary(s, row))
         except Exception:
             current_app.logger.exception("Failed to parse session %s", s["id"])
             result.append(_session_row_error(s))

tests/test_api_integration.py

@@ -148,9 +148,7 @@ def test_project_session_count_matches_list(client, summary_cache_db):
     assert project["session_count"] == len(sessions)
 
 
-def test_project_sessions_uses_disk_cache_on_second_request(
-    client, summary_cache_db, monkeypatch
-):
+def test_project_sessions_uses_disk_cache_on_second_request(client, summary_cache_db, monkeypatch):
     client.get("/api/projects/test-project/sessions")
     calls = 0
 
@@ -164,4 +162,3 @@ def counting_get_cached(path: str):
     monkeypatch.setattr("api.projects.get_cached_session", counting_get_cached)
     client.get("/api/projects/test-project/sessions")
     assert calls == 0
-

tests/test_session_summary_cache.py

@@ -4,6 +4,7 @@
 
 import os
 import shutil
+from collections.abc import Iterator
 from pathlib import Path
 
 import pytest
@@ -31,7 +32,7 @@ def sample_session(tmp_path: Path) -> Path:
 
 
 @pytest.fixture
-def cache_db(tmp_path: Path) -> Path:
+def cache_db(tmp_path: Path) -> Iterator[Path]:
     db = tmp_path / "summary.sqlite"
     reset_connection_for_tests(db)
     yield db
@@ -120,7 +121,6 @@ def test_lru_eviction(
             "none",
             summary_from_peek(quick_session_info(str(p))),
         )
-        get_summary(str(p), mtime, "none")
 
     third = paths[2]
     third_mtime = third.stat().st_mtime
@@ -136,6 +136,19 @@ def test_lru_eviction(
     assert get_summary(str(third), third_mtime, "none") is not None
 
 
+def test_put_summary_drops_stale_mtime_rows(sample_session: Path, cache_db: Path) -> None:
+    path = str(sample_session)
+    mtime = sample_session.stat().st_mtime
+    parsed = parse_session(path)
+    put_summary(path, mtime, "none", summary_from_session(parsed, is_excluded=False))
+    stat = sample_session.stat()
+    os.utime(sample_session, (stat.st_mtime + 10, stat.st_mtime + 10))
+    new_mtime = sample_session.stat().st_mtime
+    put_summary(path, new_mtime, "none", summary_from_session(parsed, is_excluded=False))
+    assert get_summary(path, mtime, "none") is None
+    assert get_summary(path, new_mtime, "none") is not None
+
+
 def test_clear_cache(sample_session: Path, cache_db: Path) -> None:
     path = str(sample_session)
     mtime = sample_session.stat().st_mtime

utils/session_path.py

@@ -41,12 +41,9 @@ def clear_display_name_cache() -> None:
         _display_name_cache.clear()
 
 
-def _project_jsonl_max_mtime(project_dir: str, jsonl_files: list[str]) -> float:
-    return max(os.path.getmtime(os.path.join(project_dir, jf)) for jf in jsonl_files)
-
-
-def _resolve_display_name(project_dir: str, jsonl_files: list[str], fallback: str) -> str:
-    max_mtime = _project_jsonl_max_mtime(project_dir, jsonl_files)
+def _resolve_display_name(
+    project_dir: str, jsonl_files: list[str], fallback: str, max_mtime: float
+) -> str:
     with _display_name_lock:
         hit = _display_name_cache.get(project_dir)
         if hit is not None and hit[0] == max_mtime:
@@ -83,7 +80,7 @@ def list_projects(base_dir: str | None = None) -> list[ProjectDict]:
             from datetime import datetime, timezone
 
             last_modified = datetime.fromtimestamp(latest_mtime, tz=timezone.utc).isoformat()
-            display_name = _resolve_display_name(project_dir, jsonl_files, name)
+            display_name = _resolve_display_name(project_dir, jsonl_files, name, latest_mtime)
             projects.append(
                 {
                     "name": name,

utils/session_summary_cache.py

@@ -16,6 +16,15 @@
 
 DEFAULT_MAX_ROWS = 2000
 
+
+def max_cache_rows() -> int:
+    """Return LRU capacity (override via CLAUDE_CODE_CHAT_BROWSER_SUMMARY_CACHE_MAX_ROWS)."""
+    raw = os.environ.get("CLAUDE_CODE_CHAT_BROWSER_SUMMARY_CACHE_MAX_ROWS", "").strip()
+    if not raw:
+        return DEFAULT_MAX_ROWS
+    return max(1, int(raw))
+
+
 _lock = threading.Lock()
 _conn: sqlite3.Connection | None = None
 
@@ -54,7 +63,9 @@ def _ensure_connection() -> sqlite3.Connection:
         return _conn
     path = cache_db_path()
     path.parent.mkdir(parents=True, exist_ok=True)
-    conn = sqlite3.connect(str(path), check_same_thread=False)
+    conn = sqlite3.connect(str(path), check_same_thread=False, timeout=30.0)
+    conn.execute("PRAGMA journal_mode=WAL")
+    conn.execute("PRAGMA busy_timeout=30000")
     conn.execute(
         """
         CREATE TABLE IF NOT EXISTS summary_cache (
@@ -102,15 +113,6 @@ def get_summary(path: str, mtime: float, rules_fingerprint: str) -> SummaryCache
         ).fetchone()
         if row is None:
             return None
-        now = time.time()
-        conn.execute(
-            (
-                "UPDATE summary_cache SET accessed_at = ? "
-                "WHERE path = ? AND mtime = ? AND rules_fp = ?"
-            ),
-            (now, abspath, mtime, rules_fingerprint),
-        )
-        conn.commit()
         return _payload_to_row(str(row[0]))
 
 
@@ -126,6 +128,10 @@ def put_summary(
     payload = _row_to_payload(row)
     with _lock:
         conn = _ensure_connection()
+        conn.execute(
+            "DELETE FROM summary_cache WHERE path = ? AND rules_fp = ? AND mtime != ?",
+            (abspath, rules_fingerprint, mtime),
+        )
         conn.execute(
             """
             INSERT INTO summary_cache (path, mtime, rules_fp, payload, accessed_at)
@@ -137,7 +143,8 @@ def put_summary(
             (abspath, mtime, rules_fingerprint, payload, now),
         )
         count = conn.execute("SELECT COUNT(*) FROM summary_cache").fetchone()
-        if count is not None and int(count[0]) > DEFAULT_MAX_ROWS:
+        limit = max_cache_rows()
+        if count is not None and int(count[0]) > limit:
             conn.execute(
                 """
                 DELETE FROM summary_cache
@@ -147,7 +154,7 @@ def put_summary(
                     LIMIT ?
                 )
                 """,
-                (int(count[0]) - DEFAULT_MAX_ROWS,),
+                (int(count[0]) - limit,),
             )
         conn.commit()