Fix PR review: stats exclusion, export_session errors, mypy 2.1, CI cache

Author: clean6378-max-it

.github/workflows/ci.yml

@@ -67,7 +67,9 @@ jobs:
         with:
           python-version: "3.12"
           cache: pip
-          cache-dependency-path: requirements-dev.txt
+          cache-dependency-path: |
+            requirements.txt
+            requirements-dev.txt
 
       - name: Install dev dependencies
         run: pip install -r requirements-dev.txt

api/export_api.py

@@ -277,30 +277,36 @@ def export_session(project_name: str, session_id: str) -> FlaskReturn:
         return json_ok({"error": "Session not found"}), 404
 
     fmt = request.args.get("format", "md")
-    session = parse_session(filepath)
-    rules = current_app.config.get("EXCLUSION_RULES") or []
-    if is_session_excluded(rules, session, project_name):
-        return json_ok({"error": "Session not found"}), 404
-    stats = compute_stats(session)
-    title_slug = slugify(session["title"], default="session")
+    try:
+        session = parse_session(filepath)
+        rules = current_app.config.get("EXCLUSION_RULES") or []
+        if is_session_excluded(rules, session, project_name):
+            return json_ok({"error": "Session not found"}), 404
+        stats = compute_stats(session)
+        title_slug = slugify(session["title"], default="session")
+
+        if fmt == "json":
+            content = session_to_json(session, stats)
+            buf = io.BytesIO(content.encode("utf-8"))
+            buf.seek(0)
+            return send_file(
+                buf,
+                mimetype="application/json",
+                as_attachment=True,
+                download_name=f"{title_slug}.json",  # type: ignore[call-arg]
+            )
 
-    if fmt == "json":
-        content = session_to_json(session, stats)
-        buf = io.BytesIO(content.encode("utf-8"))
+        md = session_to_markdown(session, stats)
+        buf = io.BytesIO(md.encode("utf-8"))
         buf.seek(0)
         return send_file(
             buf,
-            mimetype="application/json",
+            mimetype="text/markdown",
             as_attachment=True,
-            download_name=f"{title_slug}.json",  # type: ignore[call-arg]
+            download_name=f"{title_slug}.md",  # type: ignore[call-arg]
         )
-
-    md = session_to_markdown(session, stats)
-    buf = io.BytesIO(md.encode("utf-8"))
-    buf.seek(0)
-    return send_file(
-        buf,
-        mimetype="text/markdown",
-        as_attachment=True,
-        download_name=f"{title_slug}.md",  # type: ignore[call-arg]
-    )
+    except Exception:
+        current_app.logger.exception(
+            "Failed to export session %s/%s", project_name, session_id
+        )
+        return json_ok({"error": "Internal server error exporting session"}), 500

api/sessions.py

@@ -54,6 +54,9 @@ def get_session_stats(project_name: str, session_id: str) -> FlaskReturn:
 
     try:
         session = parse_session(filepath)
+        rules = current_app.config.get("EXCLUSION_RULES") or []
+        if is_session_excluded(rules, session, project_name):
+            return json_ok({"error": "Session not found"}), 404
         stats = compute_stats(session)
         return json_ok(stats)
     except Exception:

pyproject.toml

@@ -3,7 +3,3 @@ python_version = "3.12"
 strict = true
 packages = ["api", "utils", "models"]
 exclude = ["tests/"]
-
-[[tool.mypy.overrides]]
-module = "tests.*"
-ignore_errors = true

requirements-dev.txt

@@ -1,4 +1,3 @@
 -r requirements.txt
 pytest==9.0.2
-mypy==1.15.0
-types-Flask==1.1.6
+mypy==2.1.0

utils/session_path.py

@@ -52,15 +52,14 @@ def list_projects(base_dir: str | None = None) -> list[ProjectDict]:
                 latest_mtime, tz=timezone.utc
             ).isoformat()
             # Read cwd from sessions to get the real project path
-            display_name = None
+            display_name = name
             for jf in jsonl_files:
-                display_name = _get_display_name(
+                candidate = _get_display_name(
                     os.path.join(project_dir, jf), name
                 )
-                if display_name:
+                if candidate:
+                    display_name = candidate
                     break
-            if not display_name:
-                display_name = name
             projects.append({
                 "name": name,
                 "path": project_dir,