fix: address session-cache PR review feedback

Author: clean6378-max-it

tests/benchmarks/test_cache_bench.py

@@ -17,12 +17,7 @@ def _reset_cache() -> None:
 @pytest.mark.benchmark(group="cache")
 def test_cache_cold_parse(benchmark, parse_medium_file: Path) -> None:
     path = str(parse_medium_file)
-
-    def cold() -> None:
-        clear_cache()
-        get_cached_session(path)
-
-    benchmark(cold)
+    benchmark.pedantic(get_cached_session, args=(path,), setup=clear_cache)
 
 
 @pytest.mark.benchmark(group="cache")

tests/test_session_cache.py

@@ -2,8 +2,8 @@
 
 from __future__ import annotations
 
+import os
 import shutil
-import time
 from pathlib import Path
 
 import pytest
@@ -51,12 +51,38 @@ def counting_parse(p: str):
 def test_cache_invalidates_on_mtime_change(sample_session: Path) -> None:
     path = str(sample_session)
     first = get_cached_session(path)
-    time.sleep(0.05)
-    sample_session.touch()
+    stat = sample_session.stat()
+    os.utime(sample_session, (stat.st_mtime + 1, stat.st_mtime + 1))
     second = get_cached_session(path)
     assert first is not second
 
 
+def test_cache_normalizes_relative_and_absolute_paths(
+    sample_session: Path,
+    tmp_path: Path,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    calls = 0
+
+    def counting_parse(p: str):
+        nonlocal calls
+        calls += 1
+        return parse_session(p)
+
+    monkeypatch.setattr("utils.session_cache.parse_session", counting_parse)
+    rel = "session.jsonl"
+    abs_path = str(sample_session.resolve())
+    original_cwd = os.getcwd()
+    try:
+        os.chdir(tmp_path)
+        get_cached_session(rel)
+        assert calls == 1
+        get_cached_session(abs_path)
+        assert calls == 1
+    finally:
+        os.chdir(original_cwd)
+
+
 def test_lru_eviction(sample_session: Path, tmp_path: Path) -> None:
     set_max_entries(2)
     content = sample_session.read_text(encoding="utf-8")
@@ -87,3 +113,8 @@ def counting_parse(p: str):
         assert calls == 1
     finally:
         monkeypatch.undo()
+
+
+def test_set_max_entries_rejects_negative() -> None:
+    with pytest.raises(ValueError, match="non-negative"):
+        set_max_entries(-1)

utils/session_cache.py

@@ -42,6 +42,8 @@ def clear_cache() -> None:
 
 def set_max_entries(max_entries: int) -> None:
     """Override the LRU capacity (primarily for tests)."""
+    if max_entries < 0:
+        raise ValueError(f"max_entries must be non-negative, got {max_entries}")
     global _max_entries
     with _lock:
         _max_entries = max_entries