You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# Code owners — auto-requested as reviewers on matching paths.
2
2
# Last match wins; see https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
3
3
#
4
-
# Review expectation: PR authors wait for at least one CODEOWNERS approval before merge.
5
-
# Do not self-merge without review, even on docs-only changes.
4
+
# Roles:
5
+
# Development + code review: @clean6378-max-it (Chen), @timon0305 (Zilin)
6
+
# Final approval + merge: @wpak-ai (Will Pak)
7
+
#
8
+
# PR authors do not self-merge. Get a code review from Chen or Zilin, then final
Copy file name to clipboardExpand all lines: README.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -145,7 +145,7 @@ claude-code-chat-browser/
145
145
146
146
See **[`CONTRIBUTING.md`](CONTRIBUTING.md)** for full setup, conventions, and where to change each layer. New contributors should follow **[`docs/onboarding.md`](docs/onboarding.md)** for a first-PR walkthrough and reading order.
147
147
148
-
**Maintainer coverage:** commit activity is currently concentrated on a small set of identities (bus-factor risk). Mitigations: [`.github/CODEOWNERS`](.github/CODEOWNERS)for review routing and [`docs/onboarding.md`](docs/onboarding.md)so additional contributors can ramp quickly.
148
+
**Maintainer coverage:** commit activity is currently concentrated on a small set of identities (bus-factor risk). Mitigations: [`.github/CODEOWNERS`](.github/CODEOWNERS)splits development/code review (@clean6378-max-it, @timon0305) from final approval and merge (@wpak-ai), plus [`docs/onboarding.md`](docs/onboarding.md)for contributor ramp-up.
Copy file name to clipboardExpand all lines: docs/onboarding.md
+11-6Lines changed: 11 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -62,14 +62,14 @@ python app.py --port 5000
62
62
63
63
### 5. Run the full local gate
64
64
65
-
CI runs these on Ubuntu, Windows, and macOS. Run them locally before opening a PR:
65
+
Run these locally before opening a PR. In CI, **ruff** (`check` + `format --check`) runs on Ubuntu, Windows, and macOS. **mypy** runs only in the Ubuntu job; run it locally before Python-heavy changes. **pip-audit**, **pytest**, integration tests, and **Vitest** also run on all three platforms in CI.
66
66
67
67
```bash
68
-
# Lint + format (required)
68
+
# Lint + format (CI: Ubuntu + Windows + macOS)
69
69
ruff check .
70
70
ruff format --check .
71
71
72
-
# Type check (Ubuntu CI job; run locally before Python-heavy changes)
72
+
# Type check (CI: Ubuntu only)
73
73
mypy -p api -p utils -p models -p scripts
74
74
75
75
# Security audit (production deps)
@@ -102,7 +102,12 @@ Open a pull request against **`master`** on `cppalliance/claude-code-chat-browse
102
102
103
103
### 7. Review
104
104
105
-
[`.github/CODEOWNERS`](../.github/CODEOWNERS) auto-requests reviewers on new PRs. **Do not self-merge** — wait for at least one approval. Address review feedback in follow-up commits on the same branch.
105
+
[`.github/CODEOWNERS`](../.github/CODEOWNERS) auto-requests reviewers on new PRs. **Do not self-merge.**
106
+
107
+
1.**Code review** from @clean6378-max-it (Chen) or @timon0305 (Zilin). They own development and technical review on this repo.
108
+
2.**Final approval and merge** from @wpak-ai (Will Pak) after code review is done.
109
+
110
+
Address review feedback in follow-up commits on the same branch.
106
111
107
112
## Good first issues
108
113
@@ -120,7 +125,7 @@ Recent commit history is concentrated on a small set of identities. If those mai
120
125
121
126
**Mitigations in this repo:**
122
127
123
-
-**[`.github/CODEOWNERS`](../.github/CODEOWNERS)** — routes review requests so PRs do not rely on ad-hoc pings.
124
-
-**This onboarding path** — lowers the ramp for a second reviewer or contributor to run gates and ship safely.
128
+
-**[`.github/CODEOWNERS`](../.github/CODEOWNERS)** — @clean6378-max-it and @timon0305 for development and code review; @wpak-ai for final approval and merge.
129
+
-**This onboarding path** — lowers the ramp for additional contributors to run gates and ship safely.
125
130
126
131
If you are joining as a reviewer, read the [suggested reading order](#suggested-reading-order) and run the [full local gate](#5-run-the-full-local-gate) once on `master` before approving your first PR.
0 commit comments