fix(frontend): drop unused tool_types_state scaffolding

Author: clean6378-max-it

docs/architecture.md

@@ -106,7 +106,7 @@ The UI is a **hash-routed** SPA with ES modules under `static/js/`:
 - `app.js` — routing and boot
 - `projects.js`, `sessions.js`, `search.js`, `export.js` — route handlers
 - `render/registry.js` — **tool dispatch registry** for session UI: `TOOL_USE_RENDERERS` and `TOOL_RESULT_RENDERERS` map tool name / `result_type` → render function (one module per type under `render/tool_use/` and `render/tool_result/`). Parallels backend `utils/tool_dispatch.py` (backend uses ordered predicates; frontend uses direct key lookup + fallback).
-- `static/tool_types.json` — generated manifest of backend tool-use names (`python scripts/gen_tool_types_manifest.py` from `KNOWN_TOOL_TYPES`). Loaded at boot by `render/tool_types_manifest.js`, which cross-checks `TOOL_USE_RENDERERS` and logs `console.warn` on drift.
+- `static/tool_types.json` — generated manifest of backend tool-use names (`python scripts/gen_tool_types_manifest.py` from `KNOWN_TOOL_TYPES`). Fetched non-blocking at boot by `render/tool_types_manifest.js` (`void initToolTypesManifest()` in `app.js`), which cross-checks `TOOL_USE_RENDERERS` and logs `console.warn` on drift.
 - `shared/markdown.js` — markdown + **DOMPurify** sanitization (do not render raw LLM HTML)
 - `shared/state.js`, `shared/utils.js`, `shared/theme.js` — shared UI state and helpers
 

static/js/render/tool_types_manifest.js

@@ -1,5 +1,4 @@
 import { TOOL_USE_RENDERERS } from './registry.js';
-import { setManifestToolTypes } from './tool_types_state.js';
 
 const MANIFEST_URL = '/static/tool_types.json';
 const MANIFEST_FETCH_TIMEOUT_MS = 5000;
@@ -20,7 +19,6 @@ export async function initToolTypesManifest() {
         const data = await res.json();
         const types = Array.isArray(data.tool_types) ? data.tool_types : [];
         const manifest = new Set(types.filter((t) => typeof t === 'string'));
-        setManifestToolTypes(manifest);
 
         for (const name of manifest) {
             if (!Object.prototype.hasOwnProperty.call(TOOL_USE_RENDERERS, name)) {

static/js/render/tool_types_manifest.test.js

@@ -1,18 +1,14 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { initToolTypesManifest } from './tool_types_manifest.js';
-import { getManifestToolTypes, setManifestToolTypes } from './tool_types_state.js';
 import { TOOL_USE_RENDERERS } from './registry.js';
 
-// Registry drift warnings are asserted here (init-time cross-check only; no per-render warn).
-
 describe('initToolTypesManifest', () => {
     beforeEach(() => {
-        setManifestToolTypes(null);
         vi.restoreAllMocks();
     });
 
     afterEach(() => {
-        setManifestToolTypes(null);
+        vi.unstubAllGlobals();
     });
 
     it('cross-checks manifest against TOOL_USE_RENDERERS and warns on drift', async () => {
@@ -28,7 +24,6 @@ describe('initToolTypesManifest', () => {
 
         await initToolTypesManifest();
 
-        expect(getManifestToolTypes()).toEqual(new Set(manifestTypes));
         expect(warn).toHaveBeenCalledWith(
             '[tool registry] Backend tool type "FutureToolXYZ" has no TOOL_USE_RENDERERS entry',
         );
@@ -40,7 +35,6 @@ describe('initToolTypesManifest', () => {
 
         await initToolTypesManifest();
 
-        expect(getManifestToolTypes()).toBeNull();
         expect(warn).toHaveBeenCalledWith(
             '[tool registry] Could not load tool types manifest:',
             expect.any(Error),
@@ -66,7 +60,6 @@ describe('initToolTypesManifest', () => {
             await vi.advanceTimersByTimeAsync(5000);
             await promise;
 
-            expect(getManifestToolTypes()).toBeNull();
             expect(warn).toHaveBeenCalledWith(
                 '[tool registry] Could not load /static/tool_types.json: timed out after 5000ms',
             );

static/js/render/tool_types_state.js

@@ -137,17 +137,14 @@ def test_tool_name_literal_matches_known_tool_types() -> None:
 
 
 def test_frontend_registry_matches_known_tool_types() -> None:
-    """``TOOL_USE_RENDERERS`` keys must match ``KNOWN_TOOL_TYPES`` and the manifest."""
+    """``TOOL_USE_RENDERERS`` keys must match ``KNOWN_TOOL_TYPES``."""
     site = "static/js/render/registry.js (TOOL_USE_RENDERERS)"
     try:
         actual = _parse_frontend_tool_use_renderers(_FRONTEND_REGISTRY)
-        manifest = _load_manifest_tool_types(_TOOL_TYPES_MANIFEST)
     except ValueError as exc:
         pytest.fail(f"{site}: {exc}")
     if actual != KNOWN_TOOL_TYPES:
         pytest.fail(_format_set_diff(KNOWN_TOOL_TYPES, actual, site))
-    if actual != manifest:
-        pytest.fail(_format_set_diff(manifest, actual, site))
 
 
 def test_known_tool_types_nonempty() -> None: