refactor(slugify): default= kwarg, caller parity, review feedback (#30)

Author: clean6378-max-it

api/export_api.py

@@ -91,9 +91,9 @@ def bulk_export():
 
                     stats = compute_stats(session)
                     md = session_to_markdown(session, stats)
-                    title_slug = slugify(session["title"]) or "session"
+                    title_slug = slugify(session["title"], default="session")
                     short_id = sid[:8]
-                    proj_slug = slugify(project["name"]) or "project"
+                    proj_slug = slugify(project["name"], default="project")
                     ts = session["metadata"].get("first_timestamp", "")
                     ts_file = ts[:19].replace(":", "-") if ts else "0000-00-00T00-00-00"
                     rel_path = f"{proj_slug}/{ts_file}__{title_slug}__{short_id}.md"
@@ -149,7 +149,7 @@ def export_session(project_name, session_id):
     if is_session_excluded(rules, session, project_name):
         return jsonify({"error": "Session not found"}), 404
     stats = compute_stats(session)
-    title_slug = slugify(session["title"]) or "session"
+    title_slug = slugify(session["title"], default="session")
 
     if fmt == "json":
         content = session_to_json(session, stats)

scripts/export.py

@@ -367,9 +367,9 @@ def cmd_export(args):
                 meta["first_timestamp"] = ts
             date_str = ts[:10]
             ts_file = ts[:19].replace(":", "-")   # 2026-02-10T01-46-15
+            title_slug = slugify(session["title"], default="session")
             short_id = sid[:8]
-            title_slug = slugify(session["title"]) or "session"
-            project_slug = slugify(project["name"]) or "project"
+            project_slug = slugify(project["name"], default="project")
 
             if fmt in ("md", "both"):
                 md = session_to_markdown(session, stats)
@@ -445,8 +445,8 @@ def cmd_export(args):
 
 def _export_single(session: dict, stats: dict, fmt: str, out_dir: str):
     """Write one session to disk as md, json, or both."""
+    title_slug = slugify(session["title"], default="session")
     short_id = session["session_id"][:8]
-    title_slug = slugify(session["title"]) or "session"
     ts = session["metadata"].get("first_timestamp", "")
     ts_file = ts[:19].replace(":", "-") if ts else "0000-00-00T00-00-00"
 

tests/test_slugify.py

@@ -5,6 +5,8 @@
 implementation matches the API for portable zip / download filenames.
 """
 
+import os
+
 from utils.slugify import slugify
 
 
@@ -28,3 +30,31 @@ def test_empty_after_strip():
 
 def test_digits_preserved():
     assert slugify("Issue 42 Fix") == "issue-42-fix"
+
+
+def test_punctuation_examples_match_regex_behavior():
+    assert slugify("AT&T") == "at-t"
+    assert slugify("issue#42") == "issue-42"
+
+
+def test_default_used_when_slug_empty():
+    assert slugify("!!!", default="session") == "session"
+    assert slugify("!!!") == ""
+
+
+def test_export_leaf_path_parity_api_zip_vs_cli():
+    """Same session inputs → same ``proj_slug``, ``title_slug``, and file leaf as API vs CLI."""
+    title = "Issue #42: AT&T"
+    project = "Foo/Bar!"
+    sid = "a1b2c3d4-e5f6-7890-abcd-ef1234567890"
+    ts_file = "2026-05-07T12-00-00"
+    short_id = sid[:8]
+    title_slug = slugify(title, default="session")
+    proj_slug = slugify(project, default="project")
+    leaf_md = f"{ts_file}__{title_slug}__{short_id}.md"
+    api_zip_inner = f"{proj_slug}/{leaf_md}"
+    date_str = ts_file[:10]
+    cli_rel = os.path.join(date_str, proj_slug, leaf_md)
+    assert api_zip_inner.endswith(leaf_md)
+    assert os.path.basename(cli_rel) == leaf_md
+    assert cli_rel.replace("\\", "/").endswith(f"{proj_slug}/{leaf_md}")

utils/slugify.py

@@ -11,8 +11,19 @@
 import re
 
 
-def slugify(text: str) -> str:
-    """Lowercase *text* and replace each run of non-[a-z0-9] with a single hyphen."""
+def slugify(text: str, *, default: str = "") -> str:
+    """Lowercase *text* and replace each run of non-[a-z0-9] with one hyphen.
+
+    After stripping leading/trailing hyphens, returns that string; if it is
+    empty, returns *default*. Export code passes ``default="session"`` or
+    ``default="project"``.
+    Examples (handled by the ``[^a-z0-9]+`` substitution below):
+
+    - ``AT&T`` → ``at-t``
+    - ``issue#42`` → ``issue-42``
+    """
     text = text.lower()
+    # Non-ASCII-alphanumeric runs → '-'; e.g. AT&T → at-t, issue#42 → issue-42.
     text = re.sub(r"[^a-z0-9]+", "-", text)
-    return text.strip("-")
+    stripped = text.strip("-")
+    return stripped if stripped else default