Refactors, fix, and features#15
Merged
Merged
Conversation
- Add virtual do_cancel() hook to overlapped_op base class - Implement accept_op::do_cancel() calling CancelIoEx on listen socket - Wire canceller to invoke do_cancel() after request_cancel() feat: implement cancellation for read and write socket operations - Add do_cancel() implementation for read_op using CancelIoEx - Add do_cancel() implementation for write_op using CancelIoEx - Add win_socket_impl reference to read_op and write_op structs - Initialize read and write operations with socket impl in constructor fix: add cancellation support for Windows socket connect - Add impl reference and do_cancel() override to connect_op struct - Implement connect_op::do_cancel() calling CancelIoEx on the socket - Initialize conn_ member with socket impl reference in constructor chore: relocate sources and add build presets - move implementation sources under src/corosio/src and adjust build files - add CMakePresets.json default Ninja configure to out/build - note portable capy::cond comparisons in docs and public API comments - refresh ignore rules to keep build scripts while ignoring outputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usurps #11.
feat: add CancelIoEx support for accept operations on Windows
feat: implement cancellation for read and write socket operations
fix: add cancellation support for Windows socket connect
chore: relocate sources and add build presets