Skip to content

Signal set constructors#279

Merged
sgerbino merged 2 commits into
cppalliance:developfrom
sgerbino:pr/signal-set-constructors
Jun 17, 2026
Merged

Signal set constructors#279
sgerbino merged 2 commits into
cppalliance:developfrom
sgerbino:pr/signal-set-constructors

Conversation

@sgerbino

Copy link
Copy Markdown
Collaborator

Resolves #231.

sgerbino added 2 commits June 17, 2026 16:08
Mirror the executor-construction pattern used by tcp_socket and
tcp_acceptor: add a bare signal_set(Ex const&) constructor plus an
executor variant of the variadic signals constructor, each delegating
to the executor's context.

Add tests covering both new constructors.
The flamegraph action crashes in its Combine Time Traces step with
write EINVAL on the runner, independent of action version or Node
runtime: its log stream is a socket under docker exec and the writev is
rejected. The flamegraph is a non-critical compile-time diagnostic and
the time-trace matrix variant still validates the -ftime-trace build,
so mark the step continue-on-error rather than gate CI on a broken
upstream post-processing step. Also bump to v1.9.5 (latest) and rename
the github_token input to github-token to clear the deprecated-input
warning.
@cppalliance-bot

Copy link
Copy Markdown

An automated preview of the documentation is available at https://279.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-06-17 16:09:28 UTC

@cppalliance-bot

Copy link
Copy Markdown

GCOVR code coverage report https://279.corosio.prtest3.cppalliance.org/gcovr/index.html
LCOV code coverage report https://279.corosio.prtest3.cppalliance.org/genhtml/index.html
Coverage Diff Report https://279.corosio.prtest3.cppalliance.org/diff-report/index.html

Build time: 2026-06-17 16:21:53 UTC

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.69%. Comparing base (73cf3ac) to head (732f457).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #279   +/-   ##
========================================
  Coverage    77.69%   77.69%           
========================================
  Files           96       96           
  Lines         7188     7188           
  Branches      1753     1753           
========================================
  Hits          5585     5585           
  Misses        1099     1099           
  Partials       504      504           
Files with missing lines Coverage Δ
include/boost/corosio/signal_set.hpp 100.00% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cf3ac...732f457. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sgerbino sgerbino merged commit 37451d1 into cppalliance:develop Jun 17, 2026
41 checks passed
@sgerbino sgerbino deleted the pr/signal-set-constructors branch June 17, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

signal_set is missing the constructor from executor

2 participants