fix review comments from reviewer

Author: bradjin8

tests/test_workspace_path_thread_safety.py

@@ -34,14 +34,13 @@ def setUp(self):
         self.path_b = os.path.join(self.tmp, "storage-b")
         os.makedirs(self.path_a)
         os.makedirs(self.path_b)
-        self.allowed_resolved = {
-            os.path.realpath(self.path_a),
-            os.path.realpath(self.path_b),
-        }
+        # Match resolve_workspace_path() (expand_tilde only — no realpath).
+        self.allowed_resolved = {self.path_a, self.path_b}
         self._prior_workspace_env = os.environ.pop("WORKSPACE_PATH", None)
         self.addCleanup(self._restore_workspace_env)
         self.addCleanup(set_workspace_path_override, None)
-        set_workspace_path_override(None)
+        # With WORKSPACE_PATH popped and override None, this is resolve()'s
+        # "override cleared" path — used by test_concurrent_clear_and_set.
         self.fallback_resolved = resolve_workspace_path()
 
     def _restore_workspace_env(self):

utils/workspace_path.py

@@ -10,9 +10,9 @@
 from .path_helpers import expand_tilde_path
 
 # Module-level override set via POST /api/set-workspace (or --base-dir).
-# All reads and writes are serialized by _workspace_path_lock so threaded
-# WSGI workers (gunicorn --threads, waitress, etc.) cannot observe torn
-# state between set_workspace_path_override and resolve_workspace_path.
+# Reads and writes are serialized by _workspace_path_lock so threaded WSGI
+# workers (gunicorn --threads, waitress, etc.) always see the latest override
+# from another thread and resolve_workspace_path's snapshot+expand stays consistent.
 _workspace_path_lock = threading.Lock()
 _workspace_path_override: str | None = None