review: address 3 Brad findings on PR #35

* `.github/workflows/tests.yml` — block comment above the typecheck job
  still described `continue-on-error: true` as the transitional policy,
  contradicting the actual code which removed it in this same PR. Updated
  the comment to reflect the enforced gate.

* `api/logs.py` — out of issue #29's literal scope (issue lists only the
  three files I converted in the previous commit), but inconsistent with
  the "clean demo" spirit. Two `print()` error logs at lines 73 and 140
  swapped for `_logger.exception(...)` matching the pattern in
  api/workspaces.py / api/search.py / api/composers.py.

* `api/search.py:56` — `combined: list = []` is the minimum annotation
  that satisfies mypy, but `list[str]` is the actual shape: both
  content_parts and metadata_parts are typed `list[str]` upstream, the
  filter `(p for p in ... if p)` only adds truthy strings, and the
  consumer is `"\n\n".join(combined)` which requires strings. Tightened.

Verified locally:
  - mypy --ignore-missing-imports --no-strict-optional . → Success
  - ruff check api/ utils/ scripts/export.py app.py → All checks passed
  - unittest discover tests → 178 / 178 OK

Author: timon0305

.github/workflows/tests.yml

@@ -55,9 +55,9 @@ jobs:
   # Codebase already has type hints across most of the surface (~70+ typed
   # functions). Mypy runs in lenient mode (--ignore-missing-imports for
   # untyped third-party deps; no strict-optional) so the gate isn't a wall
-  # of false positives on first run. continue-on-error keeps findings as
-  # warnings during the surface-cleanup phase; flip to required by removing
-  # continue-on-error once the surface is clean.
+  # of false positives. The transitional `continue-on-error: true` was
+  # removed in #29 once mypy reached zero errors on this repo — type
+  # failures now block merges.
   typecheck:
     name: Typecheck (mypy)
     runs-on: ubuntu-latest

api/logs.py

@@ -4,6 +4,7 @@
 """
 
 import json
+import logging
 import os
 import re
 import sqlite3
@@ -16,6 +17,7 @@
 from utils.path_helpers import to_epoch_ms
 
 bp = Blueprint("logs", __name__)
+_logger = logging.getLogger(__name__)
 
 
 def _extract_chat_id_from_bubble_key(key: str) -> str | None:
@@ -69,8 +71,8 @@ def get_logs():
                         "type": "chat",
                         "messageCount": len(bubbles),
                     })
-            except Exception as e:
-                print(f"Error reading global storage: {e}")
+            except Exception:
+                _logger.exception("Error reading global storage")
 
         # Per-workspace (legacy)
         try:
@@ -136,6 +138,6 @@ def get_logs():
         logs.sort(key=lambda log: log.get("timestamp") or 0, reverse=True)
         return jsonify({"logs": logs})
 
-    except Exception as e:
-        print(f"Failed to get logs: {e}")
+    except Exception:
+        _logger.exception("Failed to get logs")
         return jsonify({"error": "Failed to get logs", "logs": []}), 500

api/search.py

@@ -53,7 +53,7 @@ def _build_exclusion_searchable(
     metadata_parts: list[str] | None = None,
 ) -> str:
     """Build broad searchable text so exclusion rules cover visible output."""
-    combined: list = []
+    combined: list[str] = []
     if content_parts:
         combined.extend(p for p in content_parts if p)
     if metadata_parts: