fix: nitpack and outside diff comments

Author: bradjin8

models/parse_warnings.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from dataclasses import dataclass
+from dataclasses import dataclass, field
 
 
 @dataclass
@@ -10,6 +10,7 @@ class ParseWarningCollector:
     composers_skipped: int = 0
     bubbles_skipped: int = 0
     composers_processing_failed: int = 0
+    source_failures: list[dict] = field(default_factory=list)
 
     def record_composer_skipped(self, count: int = 1) -> None:
         if count > 0:
@@ -24,12 +25,22 @@ def record_composer_processing_failure(self, count: int = 1) -> None:
         if count > 0:
             self.composers_processing_failed += count
 
+    def record_source_failure(self, exc: BaseException, source: str) -> None:
+        """Record a whole-source failure (e.g. the global storage DB is unreadable).
+
+        Distinct from per-item parse skips: signals that an entire data source
+        could not be searched so the API can warn callers that results may be
+        incomplete.
+        """
+        self.source_failures.append({"source": source, "detail": str(exc)})
+
     @property
     def has_warnings(self) -> bool:
         return (
             self.composers_skipped > 0
             or self.bubbles_skipped > 0
             or self.composers_processing_failed > 0
+            or bool(self.source_failures)
         )
 
     def to_api_list(self) -> list[dict]:
@@ -65,6 +76,12 @@ def to_api_list(self) -> list[dict]:
                     f"{n} {noun} could not be fully assembled after parsing"
                 ),
             })
+        for sf in self.source_failures:
+            warnings.append({
+                "type": "source_failure",
+                "source": sf["source"],
+                "detail": sf["detail"],
+            })
         return warnings
 
     def attach_to(self, payload: dict) -> dict:

services/search.py

@@ -26,10 +26,10 @@
 from pathlib import Path
 
 __all__ = [
+    "rank_results",
+    "search_cli_sessions",
     "search_global_storage",
     "search_legacy_workspaces",
-    "search_cli_sessions",
-    "rank_results",
 ]
 from models import Bubble, Composer, ParseWarningCollector, SchemaError
 from services.workspace_db import (
@@ -334,8 +334,9 @@ def search_global_storage(
                 )
                 parse_warnings.record_composer_processing_failure()
 
-    except Exception:
+    except Exception as exc:
         _logger.exception("Error searching global storage")
+        parse_warnings.record_source_failure(exc, source="global_storage")
 
     return results
 
@@ -568,7 +569,7 @@ def _ts(r: dict) -> float:
         t = r.get("timestamp", 0)
         if isinstance(t, str):
             try:
-                # .timestamp() → epoch-seconds; ×1000 → epoch-ms to match ints
+                # .timestamp() -> epoch-seconds; x1000 -> epoch-ms to match ints
                 return datetime.fromisoformat(t.replace("Z", "+00:00")).timestamp() * 1000
             except Exception:
                 return 0.0