review: fail smoke on /api/workspaces parse error (CodeRabbit)

The WS_ID extraction was suppressing python3's stderr with `2>/dev/null`
and treating a missing parse result the same as "no non-global workspace
exists". So /api/workspaces returning 200 with malformed JSON would
silently skip the three workspace-scoped probes and the script would
still exit 0 — a false green.

Wrapped the parse in `if ... ; then ... else fail=$((fail+1)); fi` so
python3's non-zero exit (raised by json.load on bad input) routes
through the FAIL printf, the workspace block is skipped explicitly,
and the script exits non-zero with the rest of the failures.

Happy path: 11/11 probes still pass.

Author: timon0305

tests/web-ui-smoke.sh

@@ -63,24 +63,31 @@ probe "/api/detect-environment"  "/api/detect-environment"  200
 probe "/api/search?q=foo"        "/api/search?q=foo"        200
 probe "/api/search (no q -> 400)" "/api/search"             400
 
-WS_ID=$(curl "${CURL_FLAGS[@]}" "$BASE/api/workspaces" | python3 -c "
+# Find a non-global workspace id to drive the workspace-scoped probes.
+# Failing to PARSE /api/workspaces is a real bug (200 with malformed JSON
+# would otherwise slip through as a false green), so the python parse
+# runs without `2>/dev/null` and exit-status is checked separately.
+if WS_ID=$(curl "${CURL_FLAGS[@]}" "$BASE/api/workspaces" | python3 -c "
 import sys, json
 data = json.load(sys.stdin)
 for w in data:
     if w.get('id') and w['id'] != 'global':
         print(w['id'])
         break
-" 2>/dev/null)
-
-if [ -n "$WS_ID" ]; then
-  echo ""
-  echo "=== Workspace-scoped routes (WS=$WS_ID) ==="
-  probe "/workspace/<id>"            "/workspace/$WS_ID"               200
-  probe "/api/workspaces/<id>"       "/api/workspaces/$WS_ID"          200
-  probe "/api/workspaces/<id>/tabs"  "/api/workspaces/$WS_ID/tabs"     200
+"); then
+  if [ -n "$WS_ID" ]; then
+    echo ""
+    echo "=== Workspace-scoped routes (WS=$WS_ID) ==="
+    probe "/workspace/<id>"            "/workspace/$WS_ID"               200
+    probe "/api/workspaces/<id>"       "/api/workspaces/$WS_ID"          200
+    probe "/api/workspaces/<id>/tabs"  "/api/workspaces/$WS_ID/tabs"     200
+  else
+    echo ""
+    echo "[skip] no non-global workspace found; workspace-scoped probes skipped"
+  fi
 else
-  echo ""
-  echo "[skip] no non-global workspace found; workspace-scoped probes skipped"
+  printf "\n  [FAIL]  %-44s parse error on /api/workspaces payload\n" "workspace-id extraction"
+  fail=$((fail + 1))
 fi
 
 echo ""