Skip to content

Commit bdd85fa

Browse files
fix: pin highlight.js script and theme with SRI (#145)
* fix: pin highlight.js script and theme with SRI * fix: don't crash workspace when highlight.js fails to load * address Will's feedback
1 parent f022aae commit bdd85fa

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

templates/base.html

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,12 @@
1616
</script>
1717
<link rel="stylesheet" href="/static/css/style.css">
1818
<!-- Highlight.js for code syntax highlighting -->
19-
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/vs2015.min.css" id="hljs-theme">
20-
<script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/highlight.min.js"></script>
19+
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/styles/vs2015.min.css" id="hljs-theme"
20+
integrity="sha512-mtXspRdOWHCYp+f4c7CkWGYPPRAhq9X+xCvJMUBVAb6pqA4U8pxhT3RWT3LP3bKbiolYL2CkL1bSKZZO4eeTew=="
21+
crossorigin="anonymous">
22+
<script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.9.0/highlight.min.js"
23+
integrity="sha512-D9gUyxqja7hBtkWpPWGt9wfbfaMGVt9gnyCvYa+jojwwPHLCzUm5i8rpk7vD7wNee9bA35eYIjobYPaQuKS1MQ=="
24+
crossorigin="anonymous"></script>
2125
<!-- Marked.js for Markdown rendering -->
2226
<script src="https://cdnjs.cloudflare.com/ajax/libs/marked/12.0.1/marked.min.js"
2327
integrity="sha384-3zf4Pen4fXU90jGg3cxmo7BF4dq8HMtF2s07c/Hhd1Fh+Encm6ApPvNm8vrMJbWu"

templates/workspace.html

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -296,9 +296,11 @@ <h2>${escapeHtml(tab.title)}</h2>
296296

297297
main.innerHTML = html;
298298

299-
main.querySelectorAll('pre code').forEach(block => {
300-
hljs.highlightElement(block);
301-
});
299+
if (typeof hljs !== 'undefined') {
300+
main.querySelectorAll('pre code').forEach(block => {
301+
hljs.highlightElement(block);
302+
});
303+
}
302304
}
303305

304306
function renderToolCall(tc) {

0 commit comments

Comments
 (0)