feat(tests): pytest endpoint coverage via Flask test client (closes #26)

.github/workflows/tests.yml

@@ -46,11 +46,17 @@ jobs:
         # system packages on Linux — out of scope for the unittest suite.
         run: |
           python -m pip install --upgrade pip
-          python -m pip install 'flask>=3.0' 'fpdf2>=2.7'
+          python -m pip install 'flask>=3.0' 'fpdf2>=2.7' 'pytest>=8'
 
       - name: Run unittest suite
         run: python -m unittest discover tests -v
 
+      - name: Run pytest integration suite
+        # Closes #26. Pytest fixtures (tests/conftest.py) build a temp
+        # workspaceStorage and exercise the Flask routes via app.test_client().
+        # Runs alongside unittest, not instead of — both suites are merge gates.
+        run: python -m pytest tests/ -v --tb=short
+
   # ── Typecheck: mypy ───────────────────────────────────────────────────────
   # Codebase already has type hints across most of the surface (~70+ typed
   # functions). Mypy runs in lenient mode (--ignore-missing-imports for

tests/conftest.py

@@ -0,0 +1,161 @@
+from __future__ import annotations
+
+import json
+import os
+import sqlite3
+import sys
+import tempfile
+from pathlib import Path
+from typing import Generator
+
+import pytest
+
+REPO_ROOT = str(Path(__file__).resolve().parent.parent)
+if REPO_ROOT not in sys.path:
+    sys.path.insert(0, REPO_ROOT)
+
+from app import create_app
+
+
+HAPPY_COMPOSER_ID = "cmp-happy"
+HAPPY_BUBBLE_ID = "bub-happy"
+HAPPY_WORKSPACE_ID = "ws-happy"
+
+
+def _make_global_state_db(path: str) -> None:
+    """globalStorage/state.vscdb with one composerData + one bubbleId row."""
+    conn = sqlite3.connect(path)
+    conn.execute("CREATE TABLE cursorDiskKV ([key] TEXT PRIMARY KEY, value TEXT)")
+    conn.execute(
+        "INSERT INTO cursorDiskKV ([key], value) VALUES (?, ?)",
+        (
+            f"composerData:{HAPPY_COMPOSER_ID}",
+            json.dumps({
+                "name": "Happy conversation",
+                "createdAt": 1_715_000_000_000,
+                "lastUpdatedAt": 1_715_000_500_000,
+                "fullConversationHeadersOnly": [
+                    {"bubbleId": HAPPY_BUBBLE_ID, "type": 1},
+                ],
+                "modelConfig": {"modelName": "gpt-4o"},
+            }),
+        ),
+    )
+    conn.execute(
+        "INSERT INTO cursorDiskKV ([key], value) VALUES (?, ?)",
+        (
+            f"bubbleId:{HAPPY_COMPOSER_ID}:{HAPPY_BUBBLE_ID}",
+            json.dumps({
+                "text": "find me by search term sentinel-grep",
+                "type": "user",
+                "createdAt": 1_715_000_400_000,
+            }),
+        ),
+    )
+    conn.commit()
+    conn.close()
+
+
+def _make_workspace(parent: str, workspace_id: str, project_folder: str) -> None:
+    """One per-workspace directory: workspace.json + minimal state.vscdb."""
+    ws_dir = os.path.join(parent, workspace_id)
+    os.makedirs(ws_dir, exist_ok=True)
+    with open(os.path.join(ws_dir, "workspace.json"), "w", encoding="utf-8") as f:
+        json.dump({"folder": project_folder}, f)
+    db = os.path.join(ws_dir, "state.vscdb")
+    conn = sqlite3.connect(db)
+    conn.execute("CREATE TABLE ItemTable ([key] TEXT PRIMARY KEY, value TEXT)")
+    conn.execute(
+        "INSERT INTO ItemTable ([key], value) VALUES (?, ?)",
+        (
+            "composer.composerData",
+            json.dumps({"allComposers": [{"composerId": HAPPY_COMPOSER_ID}]}),
+        ),
+    )
+    conn.commit()
+    conn.close()
+
+
+@pytest.fixture
+def workspace_storage() -> Generator[str, None, None]:
+    """Build a temp workspaceStorage layout and yield the workspace path.
+
+    Layout:
+        <tmp>/workspaceStorage/<HAPPY_WORKSPACE_ID>/workspace.json
+        <tmp>/workspaceStorage/<HAPPY_WORKSPACE_ID>/state.vscdb
+        <tmp>/globalStorage/state.vscdb
+        <tmp>/cli_chats/                    (empty — keeps live ~/.cursor leaking out)
+
+    Sets ``WORKSPACE_PATH`` and ``CLI_CHATS_PATH`` env vars for the duration of
+    the test and restores them on cleanup.
+    """
+    with tempfile.TemporaryDirectory() as tmp:
+        ws_root = os.path.join(tmp, "workspaceStorage")
+        global_root = os.path.join(tmp, "globalStorage")
+        cli_root = os.path.join(tmp, "cli_chats")
+        os.makedirs(ws_root, exist_ok=True)
+        os.makedirs(global_root, exist_ok=True)
+        os.makedirs(cli_root, exist_ok=True)
+
+        project_folder = os.path.join(tmp, "happy-project")
+        os.makedirs(project_folder, exist_ok=True)
+
+        _make_workspace(ws_root, HAPPY_WORKSPACE_ID, project_folder)
+        _make_global_state_db(os.path.join(global_root, "state.vscdb"))
+
+        prior_ws = os.environ.get("WORKSPACE_PATH")
+        prior_cli = os.environ.get("CLI_CHATS_PATH")
+        os.environ["WORKSPACE_PATH"] = ws_root
+        os.environ["CLI_CHATS_PATH"] = cli_root
+        try:
+            yield ws_root
+        finally:
+            if prior_ws is None:
+                os.environ.pop("WORKSPACE_PATH", None)
+            else:
+                os.environ["WORKSPACE_PATH"] = prior_ws
+            if prior_cli is None:
+                os.environ.pop("CLI_CHATS_PATH", None)
+            else:
+                os.environ["CLI_CHATS_PATH"] = prior_cli
+
+
+@pytest.fixture
+def client(workspace_storage: str):
+    """Flask test client bound to the temp workspace_storage fixture."""
+    app = create_app()
+    app.config["TESTING"] = True
+    app.config["EXCLUSION_RULES"] = []
+    return app.test_client()
+
+
+@pytest.fixture
+def empty_workspace_client() -> Generator:
+    """Flask test client bound to a workspaceStorage with no workspaces.
+
+    Useful for 404 tests where the workspace id is unknown.
+    """
+    with tempfile.TemporaryDirectory() as tmp:
+        ws_root = os.path.join(tmp, "workspaceStorage")
+        cli_root = os.path.join(tmp, "cli_chats")
+        os.makedirs(ws_root, exist_ok=True)
+        os.makedirs(cli_root, exist_ok=True)
+
+        prior_ws = os.environ.get("WORKSPACE_PATH")
+        prior_cli = os.environ.get("CLI_CHATS_PATH")
+        os.environ["WORKSPACE_PATH"] = ws_root
+        os.environ["CLI_CHATS_PATH"] = cli_root
+        try:
+            app = create_app()
+            app.config["TESTING"] = True
+            app.config["EXCLUSION_RULES"] = []
+            yield app.test_client()
+        finally:
+            if prior_ws is None:
+                os.environ.pop("WORKSPACE_PATH", None)
+            else:
+                os.environ["WORKSPACE_PATH"] = prior_ws
+            if prior_cli is None:
+                os.environ.pop("CLI_CHATS_PATH", None)
+            else:
+                os.environ["CLI_CHATS_PATH"] = prior_cli

tests/test_api_endpoints.py

@@ -0,0 +1,119 @@
+from __future__ import annotations
+
+from tests.conftest import HAPPY_BUBBLE_ID, HAPPY_COMPOSER_ID, HAPPY_WORKSPACE_ID
+
+
+# ---------------------------------------------------------------------------
+# GET /api/workspaces
+# ---------------------------------------------------------------------------
+
+class TestListWorkspaces:
+    def test_happy_path_returns_workspace_list(self, client):
+        response = client.get("/api/workspaces")
+        assert response.status_code == 200
+        body = response.get_json()
+        assert isinstance(body, list)
+
+        ids = [p["id"] for p in body]
+        assert HAPPY_WORKSPACE_ID in ids, f"expected {HAPPY_WORKSPACE_ID} in {ids}"
+
+        ws = next(p for p in body if p["id"] == HAPPY_WORKSPACE_ID)
+        assert "name" in ws
+        assert "conversationCount" in ws and isinstance(ws["conversationCount"], int)
+        assert "lastModified" in ws and "T" in ws["lastModified"]
+
+    def test_empty_storage_returns_empty_list(self, empty_workspace_client):
+        response = empty_workspace_client.get("/api/workspaces")
+        assert response.status_code == 200
+        assert response.get_json() == []
+
+
+# ---------------------------------------------------------------------------
+# GET /api/workspaces/<id>
+# ---------------------------------------------------------------------------
+
+class TestGetWorkspace:
+    def test_happy_path_returns_workspace_details(self, client):
+        response = client.get(f"/api/workspaces/{HAPPY_WORKSPACE_ID}")
+        assert response.status_code == 200
+        body = response.get_json()
+        assert body["id"] == HAPPY_WORKSPACE_ID
+        assert "name" in body
+        assert "folder" in body
+        assert "lastModified" in body and "T" in body["lastModified"]
+
+    def test_unknown_id_returns_404(self, client):
+        response = client.get("/api/workspaces/nonexistent-workspace-id")
+        assert response.status_code == 404
+        body = response.get_json()
+        assert "error" in body
+
+    def test_global_returns_other_chats(self, client):
+        response = client.get("/api/workspaces/global")
+        assert response.status_code == 200
+        body = response.get_json()
+        assert body["id"] == "global"
+        assert body["name"] == "Other chats"
+
+
+# ---------------------------------------------------------------------------
+# GET /api/workspaces/<id>/tabs
+# ---------------------------------------------------------------------------
+
+class TestGetWorkspaceTabs:
+    def test_happy_path_returns_tabs(self, client):
+        response = client.get(f"/api/workspaces/{HAPPY_WORKSPACE_ID}/tabs")
+        assert response.status_code == 200
+        body = response.get_json()
+        assert "tabs" in body and isinstance(body["tabs"], list)
+
+        tab_ids = [t["id"] for t in body["tabs"]]
+        assert HAPPY_COMPOSER_ID in tab_ids, f"expected {HAPPY_COMPOSER_ID} in {tab_ids}"
+
+        tab = next(t for t in body["tabs"] if t["id"] == HAPPY_COMPOSER_ID)
+        assert "title" in tab
+        assert "timestamp" in tab and isinstance(tab["timestamp"], int)
+        assert "bubbles" in tab and isinstance(tab["bubbles"], list)
+        # The seeded user bubble must be present
+        bubble_types = [b["type"] for b in tab["bubbles"]]
+        assert "user" in bubble_types
+
+    def test_global_returns_tabs(self, client):
+        response = client.get("/api/workspaces/global/tabs")
+        assert response.status_code == 200
+        body = response.get_json()
+        assert "tabs" in body and isinstance(body["tabs"], list)
+
+    def test_missing_global_storage_returns_404(self, empty_workspace_client):
+        response = empty_workspace_client.get("/api/workspaces/global/tabs")
+        assert response.status_code == 404
+        body = response.get_json()
+        assert "error" in body
+
+
+# ---------------------------------------------------------------------------
+# GET /api/search?q=...
+# ---------------------------------------------------------------------------
+
+class TestSearch:
+    def test_happy_path_finds_seeded_term(self, client):
+        response = client.get("/api/search?q=sentinel-grep")
+        assert response.status_code == 200
+        body = response.get_json()
+        assert "results" in body and isinstance(body["results"], list)
+        assert len(body["results"]) >= 1, f"expected sentinel match, got {body}"
+
+    def test_no_match_returns_empty_results(self, client):
+        response = client.get("/api/search?q=does-not-match-any-content-xyzzy")
+        assert response.status_code == 200
+        body = response.get_json()
+        assert "results" in body and body["results"] == []
+
+    def test_missing_q_returns_400_or_empty(self, client):
+        response = client.get("/api/search")
+        # Implementation may return 400 (missing required param) or 200 with empty.
+        # Both are reasonable for "no query supplied"; pin whichever shipped.
+        assert response.status_code in (200, 400)
+        if response.status_code == 200:
+            body = response.get_json()
+            assert "results" in body