remove move assignment from parser and serializer

Author: ashtum

include/boost/http_proto/parser.hpp

@@ -621,9 +621,6 @@ class parser
     BOOST_HTTP_PROTO_DECL
     parser(parser&& other) noexcept;
 
-    BOOST_HTTP_PROTO_DECL
-    parser& operator=(parser&& other) noexcept;
-
     BOOST_HTTP_PROTO_DECL
     ~parser();
 

include/boost/http_proto/request_parser.hpp

@@ -107,29 +107,6 @@ class request_parser
     request_parser(
         request_parser&& other) noexcept = default;
 
-    /** Assignment.
-
-        The states of `other` are transferred to
-        `this`, including the allocated buffer.
-        The previous states of `this` are
-        destroyed. After assignment, the only
-        valid operations on the moved-from object
-        are destruction and assignment.
-
-        Buffer sequences previously obtained
-        using @ref prepare or @ref pull_body
-        remain valid.
-
-        @par Complexity
-        Constant.
-
-        @return A reference to this object.
-
-        @param other The parser to assign from.
-    */
-    request_parser& operator=(
-        request_parser&& other) noexcept = default;
-
     /** Destructor.
 
         Any views or buffers obtained from this

include/boost/http_proto/response_parser.hpp

@@ -107,29 +107,6 @@ class response_parser
     response_parser(
         response_parser&& other) noexcept = default;
 
-    /** Assignment.
-
-        The states of `other` are transferred to
-        `this`, including the allocated buffer.
-        The previous states of `this` are
-        destroyed. After assignment, the only
-        valid operations on the moved-from object
-        are destruction and assignemt.
-
-        Buffer sequences previously obtained
-        using @ref prepare or @ref pull_body
-        remain valid.
-
-        @par Complexity
-        Constant.
-
-        @return A reference to this object.
-
-        @param other The parser to assign from.
-    */
-    response_parser& operator=(
-        response_parser&& other) noexcept = default;
-
     /** Destructor.
 
         Any views or buffers obtained from this

include/boost/http_proto/serializer.hpp

@@ -144,35 +144,6 @@ class serializer
     serializer(
         serializer&& other) noexcept;
 
-    /** Assignment.
-
-        The states of `other` are transferred
-        `this`, which includes the allocated buffer.
-        The previous state of `this` are destroyed.
-        After assignment, the only valid
-        operations on the moved-from object are
-        destruction and assignment.
-
-        Buffer sequences previously obtained
-        using @ref prepare or @ref stream::prepare
-        remain valid.
-
-        @par Postconditions
-        @code
-        other.is_done() == true
-        @endcode
-
-        @par Complexity
-        Constant.
-
-        @param other The serializer to assign from.
-        @return A reference to this object.
-    */
-    BOOST_HTTP_PROTO_DECL
-    serializer&
-    operator=(
-        serializer&& other) noexcept;
-
     /** Destructor
     */
     BOOST_HTTP_PROTO_DECL

src/parser.cpp

@@ -1857,16 +1857,6 @@ parser(parser&& other) noexcept
     other.impl_ = nullptr;
 }
 
-parser&
-parser::
-operator=(parser&&other) noexcept
-{
-    delete impl_;
-    impl_ = other.impl_;
-    other.impl_ = nullptr;
-    return *this;
-}
-
 parser::
 ~parser()
 {

src/serializer.cpp

@@ -958,16 +958,6 @@ serializer(serializer&& other) noexcept
     other.impl_ = nullptr;
 }
 
-serializer&
-serializer::
-operator=(serializer&&other) noexcept
-{
-    delete impl_;
-    impl_ = other.impl_;
-    other.impl_ = nullptr;
-    return *this;
-}
-
 serializer::
 ~serializer()
 {

test/unit/parser.cpp

@@ -363,34 +363,6 @@ struct parser_test
             BOOST_TEST_EQ(pr2.body(), body);
         }
 
-        // parser& operator=(parser&&)
-        {
-            rts::context ctx;
-            install_parser_service(ctx, {});
-        
-            core::string_view header =
-                "POST / HTTP/1.1\r\n"
-                "Content-Length: 3\r\n"
-                "\r\n";
-            core::string_view body = "123";
-            pieces in = { header, body };
-
-            request_parser pr1(ctx);
-            request_parser pr2(ctx);
-
-            pr1.reset();
-            pr1.start();
-            system::error_code ec;
-            read_header(pr1, in, ec);
-
-            pr2 = std::move(pr1);
-
-            BOOST_TEST_EQ(pr2.get().buffer(), header);
-            read(pr2, in, ec);
-            BOOST_TEST_NOT(ec.failed());
-            BOOST_TEST_EQ(pr2.body(), body);
-        }
-
         // ~parser
         {
             request_parser pr(ctx_);

test/unit/request_parser.cpp

@@ -215,15 +215,6 @@ struct request_parser_test
             request_parser pr1(ctx);
             request_parser pr2(std::move(pr1));
         }
-
-        // request_parser& operator=(request_parser&&)
-        {
-            rts::context ctx;
-            install_parser_service(ctx, {});
-            request_parser pr1(ctx);
-            request_parser pr2(ctx);
-            pr2 = std::move(pr1);
-        }
     }
 
     //--------------------------------------------

test/unit/response_parser.cpp

@@ -38,15 +38,6 @@ class response_parser_test
             response_parser pr1(ctx);
             response_parser pr2(std::move(pr1));
         }
-
-        // response_parser& operator=(response_parser&&)
-        {
-            rts::context ctx;
-            install_parser_service(ctx, {});
-            response_parser pr1(ctx);
-            response_parser pr2(ctx);
-            pr2 = std::move(pr1);
-        }
     }
 
     void

test/unit/serializer.cpp

@@ -253,39 +253,6 @@ struct serializer_test
             BOOST_TEST(sr2.is_done());
             BOOST_TEST(message == expected);
         }
-
-        // serializer& operator=(serializer&&)
-        {
-            std::string message;
-            buffers::string_buffer buf(&message);
-            serializer sr1(ctx);
-            sr1.start(res);
-    
-            // consume 5 bytes
-            {
-                auto cbs = sr1.prepare().value();
-                auto n = buffers::copy(buf.prepare(5), cbs);
-                sr1.consume(n);
-                buf.commit(n);
-                BOOST_TEST_EQ(n, 5);
-            }
-
-            serializer sr2(ctx);
-            sr2 = std::move(sr1);
-
-            // consume the reset from sr2
-            {
-                auto cbs = sr2.prepare().value();
-                auto n = buffers::copy(
-                    buf.prepare(buffers::size(cbs)),
-                    cbs);
-                sr2.consume(n);
-                buf.commit(n);
-            }
-
-            BOOST_TEST(sr2.is_done());
-            BOOST_TEST(message == expected);
-        }
     }
 
     //--------------------------------------------