feilds_base modifiers throw on precondition violation

Author: ashtum

include/boost/http_proto/fields_base.hpp

@@ -271,8 +271,10 @@ class fields_base
         core::string_view value,
         system::error_code& ec)
     {
-        // TODO: this should probably return an error
-        BOOST_ASSERT(id != field::unknown);
+        // Precondition violation
+        if(id == field::unknown)
+            detail::throw_logic_error();
+
         insert_impl(
             id,
             to_string(id),
@@ -486,8 +488,10 @@ class fields_base
         core::string_view value,
         system::error_code& ec)
     {
-        // TODO: this should probably return an error
-        BOOST_ASSERT(id != field::unknown);
+        // Precondition violation
+        if(id == field::unknown)
+            detail::throw_logic_error();
+
         insert_impl(
             id,
             to_string(id),
@@ -662,7 +666,7 @@ class fields_base
     */
     BOOST_HTTP_PROTO_DECL
     std::size_t
-    erase(field id) noexcept;
+    erase(field id);
 
     /** Erase all matching fields
 
@@ -821,8 +825,8 @@ class fields_base
 
         @par Complexity
 
-        @param id The field constant of the
-        header to set.
+        @param id The field name constant,
+        which may not be @ref field::unknown.
 
         @param value A value, which must be semantically
         valid for the message.

src/fields_base.cpp

@@ -591,10 +591,12 @@ shrink_to_fit() noexcept
 std::size_t
 fields_base::
 erase(
-    field id) noexcept
+    field id)
 {
-    BOOST_ASSERT(
-        id != field::unknown);
+    // Precondition violation
+    if(id == field::unknown)
+        detail::throw_logic_error();
+
 #if 1
     auto const end_ = end();
     auto it = find_last(end_, id);
@@ -830,8 +832,9 @@ set(
     core::string_view value,
     system::error_code& ec)
 {
-    BOOST_ASSERT(
-        id != field::unknown);
+    // Precondition violation
+    if(id == field::unknown)
+        detail::throw_logic_error();
 
     auto rv = verify_field_value(value);
     if(rv.has_error())

test/unit/fields_base.cpp

@@ -407,6 +407,17 @@ struct fields_base_test
             "Server: y\r\n"
             "\r\n");
 
+        check(
+            "\r\n",
+            [](fields_base& f)
+            {
+                system::error_code ec;
+                BOOST_TEST_THROWS(
+                    f.append(field::unknown, "y", ec),
+                    std::logic_error);
+            },
+            "\r\n");
+
         // append(string_view, string_view)
 
         check(
@@ -581,6 +592,19 @@ struct fields_base_test
             "T: 1\r\n"
             "\r\n");
 
+        check(
+            "T: 1\r\n"
+            "\r\n",
+            [](fields_base& f)
+            {
+                system::error_code ec;
+                BOOST_TEST_THROWS(
+                    f.insert(f.find("T"), field::unknown, "x", ec),
+                    std::logic_error);
+            },
+            "T: 1\r\n"
+            "\r\n");
+
         check(
             "T: 1\r\n"
             "U: 2\r\n"
@@ -906,6 +930,17 @@ struct fields_base_test
             "Connection: keep-alive\r\n"
             "Server: Boost\r\n"
             "\r\n");
+        
+        // unknown field id
+        check(
+            "\r\n",
+            [](fields_base& f)
+            {
+                BOOST_TEST_THROWS(
+                    f.erase(field::unknown),
+                    std::logic_error);
+            },
+            "\r\n");
     }
 
     void
@@ -1005,6 +1040,17 @@ struct fields_base_test
             "Server: y\r\n"
             "\r\n");
 
+        check(
+            "\r\n",
+            [](fields_base& f)
+            {
+                system::error_code ec;
+                BOOST_TEST_THROWS(
+                    f.set(field::unknown, "y" , ec),
+                    std::logic_error);
+            },
+            "\r\n");
+
         check(
             "T: 1\r\n"
             "Server: x\r\n"