Windows: scope C4251 suppression and remove temp quick workflow

Author: sentientsergio

.github/workflows/windows-quick.yml

@@ -10,6 +10,11 @@
 #ifndef BOOST_HTTP_PROTO_HPP
 #define BOOST_HTTP_PROTO_HPP
 
+#if defined(BOOST_MSVC)
+# pragma warning(push)
+# pragma warning(disable:4251)
+#endif
+
 #include <boost/http_proto/error.hpp>
 #include <boost/http_proto/field.hpp>
 #include <boost/http_proto/fields.hpp>
@@ -52,4 +57,8 @@
 #include <boost/http_proto/server/route_handler.hpp>
 #include <boost/http_proto/server/router_types.hpp>
 
+#if defined(BOOST_MSVC)
+# pragma warning(pop)
+#endif
+
 #endif

include/boost/http_proto.hpp

@@ -33,18 +33,6 @@ namespace http_proto {
 #  define BOOST_HTTP_PROTO_DECL
 # endif
 
-// MSVC-only helpers to locally suppress benign DLL-interface warnings
-# if defined(BOOST_MSVC)
-#  define BOOST_HTTP_PROTO_MSVC_WARNING_PUSH __pragma(warning(push))
-#  define BOOST_HTTP_PROTO_MSVC_WARNING_POP  __pragma(warning(pop))
-#  define BOOST_HTTP_PROTO_MSVC_DISABLE_4251_4275 \
-    __pragma(warning(disable:4251 4275))
-# else
-#  define BOOST_HTTP_PROTO_MSVC_WARNING_PUSH
-#  define BOOST_HTTP_PROTO_MSVC_WARNING_POP
-#  define BOOST_HTTP_PROTO_MSVC_DISABLE_4251_4275
-# endif
-
 # if !defined(BOOST_HTTP_PROTO_SOURCE) && !defined(BOOST_ALL_NO_LIB) && !defined(BOOST_HTTP_PROTO_NO_LIB)
 #  define BOOST_LIB_NAME boost_http_proto
 #  if defined(BOOST_ALL_DYN_LINK) || defined(BOOST_HTTP_PROTO_DYN_LINK)

include/boost/http_proto/detail/config.hpp

@@ -24,6 +24,11 @@
 
 #include <cstdint>
 
+#if defined(BOOST_MSVC)
+# pragma warning(push)
+# pragma warning(disable:4251)
+#endif
+
 namespace boost {
 namespace http_proto {
 
@@ -44,8 +49,6 @@ struct empty
     kind param;
 };
 
-BOOST_HTTP_PROTO_MSVC_WARNING_PUSH
-BOOST_HTTP_PROTO_MSVC_DISABLE_4251_4275
 
 struct BOOST_HTTP_PROTO_DECL header
 {
@@ -221,7 +224,10 @@ struct BOOST_HTTP_PROTO_DECL header
         system::error_code&) noexcept;
 };
 
-BOOST_HTTP_PROTO_MSVC_WARNING_POP
+#if defined(BOOST_MSVC)
+# pragma warning(pop)
+#endif
+
 
 } // detail
 } // http_proto

include/boost/http_proto/detail/header.hpp

@@ -19,6 +19,11 @@
 
 #include <iosfwd>
 
+#if defined(BOOST_MSVC)
+# pragma warning(push)
+# pragma warning(disable:4251)
+#endif
+
 namespace boost {
 namespace http_proto {
 
@@ -1398,4 +1403,8 @@ class BOOST_HTTP_PROTO_DECL fields_base
 
 #include <boost/http_proto/impl/fields_base.hpp>
 
+#if defined(BOOST_MSVC)
+# pragma warning(pop)
+#endif
+
 #endif

include/boost/http_proto/fields_base.hpp

@@ -15,6 +15,11 @@
 #include <boost/http_proto/fields_base.hpp>
 #include <boost/core/detail/string_view.hpp>
 
+#if defined(BOOST_MSVC)
+# pragma warning(push)
+# pragma warning(disable:4251)
+#endif
+
 namespace boost {
 namespace http_proto {
 
@@ -187,6 +192,10 @@ class BOOST_HTTP_PROTO_DECL message_base
     set_keep_alive(bool value);
 };
 
+#if defined(BOOST_MSVC)
+# pragma warning(pop)
+#endif
+
 } // http_proto
 } // boost
 

include/boost/http_proto/message_base.hpp

@@ -18,6 +18,10 @@
 #include <boost/http_proto/header_limits.hpp>
 #include <boost/http_proto/sink.hpp>
 
+#if defined(BOOST_MSVC)
+# pragma warning(push)
+# pragma warning(disable:4251)
+#endif
 #include <boost/buffers/dynamic_buffer.hpp>
 #include <boost/buffers/buffer_pair.hpp>
 #include <boost/core/span.hpp>
@@ -778,4 +782,8 @@ install_parser_service(
 
 #include <boost/http_proto/impl/parser.hpp>
 
+#if defined(BOOST_MSVC)
+# pragma warning(pop)
+#endif
+
 #endif

include/boost/http_proto/parser.hpp

@@ -12,6 +12,11 @@
 
 #include <boost/http_proto/request_base.hpp>
 
+#if defined(BOOST_MSVC)
+# pragma warning(push)
+# pragma warning(disable:4251)
+#endif
+
 namespace boost {
 namespace http_proto {
 
@@ -452,6 +457,10 @@ class BOOST_HTTP_PROTO_DECL request
     }
 };
 
+#if defined(BOOST_MSVC)
+# pragma warning(pop)
+#endif
+
 } // http_proto
 } // boost
 

include/boost/http_proto/request.hpp

@@ -14,6 +14,11 @@
 #include <boost/http_proto/detail/config.hpp>
 #include <boost/http_proto/message_base.hpp>
 
+#if defined(BOOST_MSVC)
+# pragma warning(push)
+# pragma warning(disable:4251)
+#endif
+
 namespace boost {
 namespace http_proto {
 
@@ -298,6 +303,10 @@ class BOOST_HTTP_PROTO_DECL request_base
         http_proto::version v);
 };
 
+#if defined(BOOST_MSVC)
+# pragma warning(pop)
+#endif
+
 } // http_proto
 } // boost