rename enum

Author: MungoG

include/boost/http_proto/serializer.hpp

@@ -534,6 +534,22 @@ class serializer
     bool
     is_done() const noexcept;
 
+    /** Return true if headers have been set.
+
+        Returns `true` if @ref set_headers has been
+        called and no @ref start or @ref start_stream
+        function has been called since. This indicates
+        that the serializer is ready to begin
+        serialization with a body style.
+
+        @see
+            @ref set_headers,
+            @ref is_done.
+    */
+    BOOST_HTTP_PROTO_DECL
+    bool
+    is_headers_set() const noexcept;
+
     /** Set the message headers for serialization.
 
         This function prepares the serializer with the
@@ -817,10 +833,6 @@ class serializer
     detail::workspace&
     ws();
 
-    BOOST_HTTP_PROTO_DECL
-    void
-    start_empty_impl();
-
     BOOST_HTTP_PROTO_DECL
     void
     start_buffers_impl(
@@ -831,10 +843,6 @@ class serializer
     start_source_impl(
         source&);
 
-    BOOST_HTTP_PROTO_DECL
-    stream
-    start_stream_impl();
-
     impl* impl_ = nullptr;
 };
 

src/serializer.cpp

@@ -282,7 +282,7 @@ class serializer::impl
     enum class state
     {
         reset,
-        start,
+        initialized,
         headers_set,
         header,
         body
@@ -309,7 +309,7 @@ class serializer::impl
     detail::array_of_const_buffers prepped_;
     buffers::const_buffer tmp_;
 
-    state state_ = state::start;
+    state state_ = state::initialized;
     style style_ = style::empty;
     uint8_t chunk_header_len_ = 0;
     bool more_input_ = false;
@@ -333,7 +333,7 @@ class serializer::impl
     reset() noexcept
     {
         ws_.clear();
-        state_ = state::start;
+        state_ = state::initialized;
     }
 
     auto
@@ -639,11 +639,11 @@ class serializer::impl
         message_base const& m)
     {
         // Precondition violation
-        if(state_ != state::start)
+        if(state_ != state::initialized)
             detail::throw_logic_error();
 
         // TODO: To uphold the strong exception guarantee,
-        // `state_` must be reset to `state::start` if an
+        // `state_` must be reset to `state::initialized` if an
         // exception is thrown during the start operation.
         state_ = state::headers_set;
 
@@ -880,7 +880,13 @@ class serializer::impl
     bool
     is_done() const noexcept
     {
-        return state_ == state::start;
+        return state_ == state::initialized;
+    }
+
+    bool
+    is_headers_set() const noexcept
+    {
+        return state_ == state::headers_set;
     }
 
     detail::workspace&
@@ -1093,22 +1099,22 @@ is_done() const noexcept
     return impl_->is_done();
 }
 
-//------------------------------------------------
-
-detail::workspace&
+bool
 serializer::
-ws()
+is_headers_set() const noexcept
 {
     BOOST_ASSERT(impl_);
-    return impl_->ws();
+    return impl_->is_headers_set();
 }
 
-void
+//------------------------------------------------
+
+detail::workspace&
 serializer::
-start_empty_impl()
+ws()
 {
     BOOST_ASSERT(impl_);
-    impl_->start_empty_impl();
+    return impl_->ws();
 }
 
 void
@@ -1129,14 +1135,6 @@ start_source_impl(
     impl_->start_source_impl(source);
 }
 
-auto
-serializer::
-start_stream_impl() -> stream
-{
-    BOOST_ASSERT(impl_);
-    return impl_->start_stream_impl();
-}
-
 //------------------------------------------------
 
 std::size_t