Skip to content

Revert "workaround boost.span non-SFINAE friendly constructor" #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashtum merged 1 commit into from
Oct 24, 2025
Merged

Revert "workaround boost.span non-SFINAE friendly constructor" #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions include/boost/http_proto/impl/sink.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,9 @@ write_impl(
while(
p != tmp_end &&
it != end_);
rv += on_write(
true,
boost::span<
buffers::const_buffer const>(
tmp, p - tmp),
rv += on_write(boost::span<
buffers::const_buffer const>(
tmp, p - tmp),
it != end_ || more);
if(rv.ec.failed())
return rv;
Expand Down
8 changes: 3 additions & 5 deletions include/boost/http_proto/impl/source.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,9 @@ read_impl(
while(
p != tmp_end &&
it != end_);
rv += on_read(
true,
boost::span<
buffers::mutable_buffer const>(
tmp, p - tmp));
rv += on_read(boost::span<
buffers::mutable_buffer const>(
tmp, p - tmp));
if(rv.ec.failed())
return rv;
if(rv.finished)
Expand Down
15 changes: 7 additions & 8 deletions include/boost/http_proto/sink.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ struct BOOST_SYMBOL_VISIBLE
virtual
results
on_write(
bool boost_span_issue_202_workaround,
boost::span<const buffers::const_buffer> bs,
bool more);

Expand All @@ -213,13 +212,13 @@ struct BOOST_SYMBOL_VISIBLE
return on_write(b, more);
}

// results
// write_impl(
// boost::span<const buffers::const_buffer> const& bs,
// bool more)
// {
// return on_write(bs, more);
// }
results
write_impl(
boost::span<const buffers::const_buffer> const& bs,
bool more)
{
return on_write(bs, more);
}

template<class T>
results
Expand Down
13 changes: 6 additions & 7 deletions include/boost/http_proto/source.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ struct BOOST_SYMBOL_VISIBLE
virtual
results
on_read(
bool boost_span_issue_202_workaround,
boost::span<buffers::mutable_buffer const> bs);

private:
Expand All @@ -206,12 +205,12 @@ struct BOOST_SYMBOL_VISIBLE
return on_read(b);
}

// results
// read_impl(
// boost::span<buffers::mutable_buffer const> const& bs)
// {
// return on_read(bs);
// }
results
read_impl(
boost::span<buffers::mutable_buffer const> const& bs)
{
return on_read(bs);
}

template<class T>
results
Expand Down
1 change: 0 additions & 1 deletion src/sink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ namespace http_proto {
auto
sink::
on_write(
bool,
boost::span<buffers::const_buffer const> bs,
bool more) ->
results
Expand Down
1 change: 0 additions & 1 deletion src/source.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace http_proto {
auto
source::
on_read(
bool,
boost::span<buffers::mutable_buffer const> bs) ->
results
{
Expand Down
Loading