Merge pull request #380 from cppalliance/379

Fix useless cast from decimal

Author: mborland

include/boost/int128/detail/int128_imp.hpp

@@ -3264,7 +3264,7 @@ BOOST_INT128_HOST_DEVICE constexpr int128_t operator%(const int128_t lhs, const
     }
     #else
 
-    const auto is_neg{static_cast<bool>(lhs < 0)};
+    const auto is_neg{lhs < 0};
 
     int128_t remainder {};
 

include/boost/int128/detail/mini_from_chars.hpp

@@ -183,7 +183,7 @@ BOOST_INT128_HOST_DEVICE constexpr int from_chars_integer_impl(const char* first
     }
 
     // Return the parsed value, adding the sign back if applicable
-    // If we have overflowed then we do not return the result
+    // If we have overflowed, then we do not return the result
     if (overflowed)
     {
         return EDOM;
@@ -201,7 +201,18 @@ BOOST_INT128_HOST_DEVICE constexpr int from_chars_integer_impl(const char* first
 
     // This value will be negative to differentiate from errno values
     // since they are in the range of acceptable distances
+
+    // This cast is useless on 32-bit platforms
+    #if defined(__GNUC__) && !defined(__clang__)
+    #  pragma GCC diagnostic push
+    #  pragma GCC diagnostic ignored "-Wuseless-cast"
+    #endif
+
     return static_cast<int>(first - next);
+
+    #if defined(__GNUC__) && !defined(__clang__)
+    #  pragma GCC diagnostic pop
+    #endif
 }
 } // namespace impl